-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing documentation upstream? (Document how $HOME is set on Windows) #5282
Comments
Git documentation refers to $HOME and $XDG_CONFIG_HOME often, but does not specify how or where these values come from on Windows where neither is set by default. The new documentation reflects the behavior of setup_windows_environment() in compat/mingw.c. Signed-off-by: Alejandro Barreto <[email protected]>
Yes, and yes ;-)
Too true. A lot of Git for Windows' patches have to be upstreamed, and I'll be honest with you: The reason why I don't spend more time on upstreaming these patches is the process that requires sending patches to a mailing list where reviewers' priorities seem to diverge from mine... If you want to take some of that burden from my shoulders, I would be delighted. |
Upstream PR at gitgitgadget#1834 ready to send |
This PR was merged (or more correctly: The Git project, being still a fan of mailing lists, applied the patches exported from that PR and created completely new commits that were then merged). |
Migrating the discussion in a commit comment to an issue.
Here's what @hickford said in 4931518#commitcomment-149554802:
I'll be honest, I'm not sure. Maybe it's cause this is the Windows version of Git, and perhaps this functionality wasn't upstream?
Here's what I'm finding:
Seems like that July 2019 commit should have included my documentation change.
The text was updated successfully, but these errors were encountered: