comment about datacondition type

ceorourke · ceorourke · commit 3ce2b4d5ff00 · 2024-11-12T14:29:34.000-08:00
diff --git a/src/sentry/workflow_engine/migrations/0012_migrate_metric_alerts.py b/src/sentry/workflow_engine/migrations/0012_migrate_metric_alerts.py
@@ -140,7 +140,7 @@ def migrate_metric_alerts(apps: Apps, schema_editor: BaseDatabaseSchemaEditor) -
                 condition=trigger.threshold_type,
                 comparison=trigger.alert_threshold,
                 condition_result=condition_result,
-                type=DataSourceType.SNUBA_QUERY_SUBSCRIPTION,  # is this correct?
+                type="metric_alert",  # this will probably change by the time we actually do the migration
             )
             # missing DataConditionDetails because this table doesn't exist yet
         trigger_actions = AlertRuleTriggerAction.objects.filter(

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ def migrate_metric_alerts(apps: Apps, schema_editor: BaseDatabaseSchemaEditor) -`
`140`	`140`	`condition=trigger.threshold_type,`
`141`	`141`	`comparison=trigger.alert_threshold,`
`142`	`142`	`condition_result=condition_result,`
`143`		`- type=DataSourceType.SNUBA_QUERY_SUBSCRIPTION, # is this correct?`
	`143`	`+ type="metric_alert", # this will probably change by the time we actually do the migration`
`144`	`144`	`)`
`145`	`145`	`# missing DataConditionDetails because this table doesn't exist yet`
`146`	`146`	`trigger_actions = AlertRuleTriggerAction.objects.filter(`