-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of license files outside of the LICENSE folder #1070
Comments
Hi @cordlandwehr. Can you provide a link to an example repository? I'm interested in seeing the status quo. |
@carmenbianca here is one of such repos: https://invent.kde.org/packaging/yocto-meta-kf6/-/tree/master |
Hmmm… This is not a trivial one. I propose a few changes (loosely, brainstorming without overly much consideration), which will need to be reflected in the spec:
However, if I don't misunderstand, the real problem is that REUSE makes you declare copyright and licensing for the files in Maybe a better solution, even if not ideal, is to glob that directory as 'Copyright = None/Various Authors' and 'SPDX-ID = LicenseRef-LicenseText' in Happy to brainstorm further with you. You've hit an interesting corner case. |
Hi, thank you for the detailed comment. Those points are very close to what I was thinking. As a short term solution I will do the approach with globbing these license files in REUSE.toml and adding a LicenceRef- file that explains them just being licenses. A proper solution though would be, in my opinion, that we can mark a file/multiple files to be a license file that is used exclusively as file artefact, which eg. is copied in the install step. And in this situation also the exclusion rules apply as for "normal" license files. |
Hmm, I think maybe the problem is more abstract than that. The problem isn't that these are licence files; the problem is that they are unlicensed files. For licences, it's a metadata-of-metadata problem. What licence is a licence text under? (And recursively, if the licence text has a licence, how is that licence licensed?) This metadata-of-metadata problem is why I merged fsfe/reuse-website#83 recently. But licence files aside, this happens more often. In https://github.com/fsfe/reuse-website I just realise that we incorrectly label the logo image files of third parties as CC-BY-SA-4.0. But fixing that would be tricky; are they proprietary? Are the licensed? For the FSFE logo, we use this halfway licence, which I assume was copied from the FSFE website at some point. The easiest and probably most correct solution is to slap An even easier solution would be to say 'I really don't want to care about these files, please make the problem go away', and implement a way for REUSE to just ignore files. However, every time we've discussed such a thing internally, we've all agreed that implementing this is a terrible idea. I don't yet have a perfect magical solution for this. I will create an issue to maybe expand on this in the website's FAQ. |
In the Yocto packaging world there I have the following use case:
All this makes reuse lint fail for me unless I assign a license to the license text file. By the same arguments why all files in LICENSES/ are also not included in the linter, I propose to add an option to e.g. the REUSE.toml file to define additional folders of licenses for which reuse lint does not complain when their licenses are not additionally stated.
The text was updated successfully, but these errors were encountered: