Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fill): make transaction a pytest fixture #1065

Open
raxhvl opened this issue Jan 9, 2025 · 0 comments
Open

feat(fill): make transaction a pytest fixture #1065

raxhvl opened this issue Jan 9, 2025 · 0 comments
Labels
scope:fill Scope: fill command type:feat type: Feature

Comments

@raxhvl
Copy link
Contributor

raxhvl commented Jan 9, 2025

A transaction is a function of fork. Often times fork specific transaction payload is constructed within a test.

        protected=False if fork in [Frontier, Homestead] else True,

A possible solution could be to make tx a pytest fixture (as pre is right now) which would allow automatic setting of the protected field based on the value of fork (which is also a pytest fixture). tx would have to be specified in the function arguments, as is pre right now.

it's a possible solution that would allow generalization of transactions for other chains, unlocking EEST for L2 EVM testing.

Originally posted by @danceratopz in #975 (comment)

@danceratopz danceratopz changed the title Make transaction a pytest fixture feat(fill): make transaction a pytest fixture Feb 5, 2025
@danceratopz danceratopz added type:feat type: Feature scope:fill Scope: fill command labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fill Scope: fill command type:feat type: Feature
Projects
None yet
Development

No branches or pull requests

2 participants