Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: add functionality to test esquery selectors #79

Open
1 task done
pkerschbaum opened this issue Feb 2, 2025 · 2 comments · May be fixed by #80
Open
1 task done

Suggestion: add functionality to test esquery selectors #79

pkerschbaum opened this issue Feb 2, 2025 · 2 comments · May be fixed by #80
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion enhancement New feature or request

Comments

@pkerschbaum
Copy link

What problem do you want to solve?

It is difficult to test selectors of the rule no-restricted-syntax, or esquery selectors in general (which is the underlying AST query library).

What do you think is the correct solution?

It would be great if the ESLint Code Explorer had some functionality to test selectors.
E.g. some text input to enter the esquery selector, and it would highlight the code & AST nodes which match.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

If this idea is accepted, I could try to come up with mockups.
@pkerschbaum pkerschbaum added the enhancement New feature or request label Feb 2, 2025
@nzakas
Copy link
Member

nzakas commented Feb 3, 2025

I think this is a great idea. Mockups welcome! 🙏

@nzakas nzakas added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 3, 2025
@nzakas nzakas added this to Triage Feb 3, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Feb 3, 2025
@nzakas nzakas moved this from Needs Triage to Ready to Implement in Triage Feb 3, 2025
pkerschbaum added a commit to pkerschbaum/eslint-code-explorer that referenced this issue Feb 9, 2025
@pkerschbaum
feat: Add esquery selector textfield & highlighting of matched code
1102a4b 
Fixes eslint#79
pkerschbaum added a commit to pkerschbaum/eslint-code-explorer that referenced this issue Feb 9, 2025
@pkerschbaum
feat: Add esquery selector textfield & highlighting of matched code
dadf787 
Fixes eslint#79
@pkerschbaum pkerschbaum linked a pull request Feb 9, 2025 that will close this issue
Open
1 task
@pkerschbaum
Copy link
Author

@nzakas it was actually easier for me to just implement a version, I suggest to continue discussion there: #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion enhancement New feature or request
Projects
Triage
Status: Ready to Implement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add esquery selector textfield & highlighting of matched code pkerschbaum/eslint-code-explorer
2 participants
@nzakas @pkerschbaum