Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmg maker (Intel): Cannot find module '../build/Release/volume.node' #3845

Open
3 tasks done
WyattBlue opened this issue Feb 9, 2025 · 0 comments
Open
3 tasks done

Comments

@WyattBlue
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Forge version

7.6.1

Electron version

v33.4.0

Operating system

macOS 14.7.3 (Intel)

Last known working Forge version

7.5.0

Expected behavior

npm run make

Makes the app and dmg without errors

Actual behavior

The .app is made but the dmg maker fails.

❯ Making distributables
  ✖ Making a dmg distributable for darwin/x64
    › Cannot find module '../build/Release/volume.node'
      Require stack:
      - /Users/wyattblue/projects/app/node_modules/macos-alias/lib/create.js
      - /Users/wyattblue/projects/app/node_modules/macos-alias/index.js
      - /Users/wyattblue/projects/app/node_modules/ds-store/index.js
      - /Users/wyattblue/projects/app/node_modules/appdmg/lib/appdmg.js
      - /Users/wyattblue/projects/app/node_modules/appdmg/index.js
      - /Users/wyattblue/projects/app/node_modules/electron-installer-dmg/dist/i
      ndex.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/maker-dmg/dis
      t/MakerDMG.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/helper/d
      ynamic-import.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/uti
      l/forge-config.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/uti
      l/index.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/api
      /index.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/cli/dist/elec
      tron-forge-make.js
◼ Running postMake hook

An unhandled rejection has occurred inside Forge:
Error: Cannot find module '../build/Release/volume.node'
Require stack:
- /Users/wyattblue/projects/app/node_modules/macos-alias/lib/create.js
- /Users/wyattblue/projects/app/node_modules/macos-alias/index.js
- /Users/wyattblue/projects/app/node_modules/ds-store/index.js
- /Users/wyattblue/projects/app/node_modules/appdmg/lib/appdmg.js
- /Users/wyattblue/projects/app/node_modules/appdmg/index.js
- /Users/wyattblue/projects/app/node_modules/electron-installer-dmg/dist/index.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/maker-dmg/dist/MakerDMG.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/helper/dynamic-import.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/util/forge-config.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/util/index.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/api/index.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/cli/dist/electron-forge-make.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/Users/wyattblue/projects/app/node_modules/macos-alias/lib/create.js:7:13)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/Users/wyattblue/projects/app/node_modules/macos-alias/index.js:1:18)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)

Steps to reproduce

npx create-electron-app my-new-app
cd my-new-app
vim forge.config.js  # replace Darwin zip target with maker-dmg
npm run make

I'm using this maker

    {
      name: "@electron-forge/maker-dmg",
      platforms: ["darwin"],
      config: {
        format: "ULFO",
        iconSize: 150,
        overwrite: true,
      }
    },

The error only happens on Intel. on Apple Silicon (same OS version) the error doesn't happen.

Additional information

I tried downgrading from 7.6.1 to 7.5.0 but I still get the same problem. I don't think the actual problem is in forge itself, but with a transitive dependency, which I think is appdmg.

appdmg is nice, but it hasn't had any updates in 2 years. I would like for that dependency to be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant