-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot create projects with swift extension #14714
Comments
That looks like the extension is trying to load something from VS Code's |
I think @msujew knows a bit about platform-specific extensions. Maybe he has an idea? |
We have a similar issue for another extension: #14638 i.e. some extensions expect some binaries in specific places in the delivery |
I am just wary of setting up another regular task where we have to track the node_modules folder in VS code. Maybe we just should set up some "common library" of node modules that we make available in the plugin host. The trouble is then if folks rely on behavior of a particular version (e.g. node-pty has many preview versions). The same will happen to extensions as VS code updates their versions of packaged node modules, though. |
I think a low effort approach to place some of our dependencies/binaries in the same location as VS Code does, makes sense. Just to be a bit more compatible in a pragmatic fashion. I completely agree with @tsmaeder that we should not try to replicate VS Code's environment 100% as this will require a lot of work and is not encouraged anyway. |
@sdirix With the current webpack/bundling setup, it's rather complicated to exclude specific dependencies to remain inside the I've provided a PR #14720 to fix any extension that specifically requires the |
Bug Description:
Cannot create new project with the swift extension
Steps to Reproduce:
Additional Information
The text was updated successfully, but these errors were encountered: