Skip to content

Commit 58a4c6e

Browse files
authored
test: unskip Server Push tests (#108)
1 parent 4876688 commit 58a4c6e

File tree

4 files changed

+1347
-17
lines changed

4 files changed

+1347
-17
lines changed

server_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
"net/url"
1010
"os"
1111
"os/exec"
12-
"strings"
1312
"testing"
1413
"time"
1514

@@ -127,10 +126,6 @@ func TestH2Push(t *testing.T) {
127126

128127
for _, test := range []string{"fields-query", "fields-header", "preload-query", "preload-header", "fields-preload-query", "fields-preload-header"} {
129128
t.Run(test, func(t *testing.T) {
130-
if strings.Contains(test, "preload") {
131-
t.Skip("HTTP/2 Server Push support is broken in PHP")
132-
}
133-
134129
cmd := exec.Command("./test-push/" + test + ".php")
135130
cmd.Env = os.Environ()
136131
cmd.Env = append(cmd.Env, "GATEWAY_URL="+gatewayURL)
@@ -145,7 +140,6 @@ func TestH2Push(t *testing.T) {
145140
}
146141

147142
func TestH2PushLimit(t *testing.T) {
148-
t.Skip("HTTP/2 Server Push support is broken in PHP")
149143
upstream, s, _ := createTestingUtils("", 2)
150144
defer upstream.Close()
151145

@@ -161,7 +155,6 @@ func TestH2PushLimit(t *testing.T) {
161155
}
162156

163157
func TestH2PushOpenAPI(t *testing.T) {
164-
t.Skip("HTTP/2 Server Push support is broken in PHP")
165158
upstream, g, _ := createTestingUtils(openapiFixture, -1)
166159
defer upstream.Close()
167160

test-push/composer.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
"require": {
33
"php": ">=8.1",
44

5-
"symfony/http-client": "^6.2.2",
6-
"sebastian/diff": "^4.0.4"
5+
"symfony/http-client": "^6.2.6",
6+
"sebastian/diff": "^4.0.4",
7+
"amphp/http-client": "^4.6.2"
78
}
89
}

0 commit comments

Comments
 (0)