Checkcfg template doesn't auto escape keywords

[GrahamPearsonAvaloq]

Actual Result:
Register some catalog with a keyword (e.g. check) in the package name, and we see unresolved references, parsing failure, and generally quite broken checkcfg. I imagine lots of customers have "check" as part of the package and therefore this has high impact.

Expected Result:
where keywords are present, they should be escaped with ^

Steps to Reproduce:
Register some catalog with a keyword (e.g. check) in the package name, and we see unresolved references, parsing failure, and generally quite broken checkcfg. I imagine lots of customers have "check" as part of the package and therefore this has high impact.

[knutwannheden]

I probably don't quite understand the actual problem. But escape sequences should of course only appear in the serialized text form. In the strings in the AST model there should be no ^ symbols, otherwise there is a corresponding entry in the IValueConverterService missing. That is why I don't quite understand why you would change the IQualifiedNameConverter...

[GrahamPearsonAvaloq]

If you use the "Add catalog" template in a CheckCfg file, and the package name of the catalog includes a checkcfg keyword (e.g. "catalog my.own.check.package.MyCatalog {}"), then the keyword does not get escaped and you get an error e.g. "Couldn't resolve reference to CheckCatalog 'my.own'.

Is IQualifiedNameConverter the wrong place to add the escape characters?