Skip to content

Commit 8ccf302

Browse files
committed
Remove image size tests pipelines and documentation (#6403)
1 parent 5e487ec commit 8ccf302

10 files changed

+2
-544
lines changed

.github/ISSUE_TEMPLATE/releases/dotnet-release-lifecycle.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ Add due dates to each of the issues so that we don't lose track of them.
3434
- [ ] Update readmes
3535
- [ ] Update the [MCR tags metadata templates](https://github.com/dotnet/dotnet-docker/tree/main/eng/mcr-tags-metadata-templates) to include the new distro version
3636
- The new tags should be in a preview sub-table, like so: <https://github.com/dotnet/dotnet-docker/blob/8fc28db4f706d81a1fd075f2c6b2ca514ae75c84/eng/mcr-tags-metadata-templates/aspnet-tags.yml#L1-L3>
37-
- [ ] Update image size baselines
38-
- [ ] Queue a build of the [dotnet-docker-nightly](https://dev.azure.com/dnceng/internal/_build?definitionId=359) pipeline
39-
- [ ] Inspect the image sizes by pulling the new images from the `dotnetdocker` ACR and update the baselines accordingly
4037

4138
## Preview 1
4239

@@ -91,7 +88,6 @@ Create announcement:
9188
- [ ] [TestData.cs](/tests/Microsoft.DotNet.Docker.Tests/TestData.cs)
9289
- [ ] [mcr-tags-metadata-templates](/eng/mcr-tags-metadata-templates)
9390
- [ ] [Featured tags](/eng/readme-templates/FeaturedTags.md)
94-
- [ ] [Image size tests](/tests/performance)
9591
- [ ] Delete the Dockerfiles
9692
- [ ] Search for and simplify conditions including the EOL .NET Version in the Dockerfile templates and tests
9793
- [ ] Update the path variable appropriately for the [dotnet-docker-nightly-pr-no-cache](https://dev.azure.com/dnceng-public/public/_build?definitionId=184) pipeline so that it continues to target active Dockerfiles.

.github/ISSUE_TEMPLATE/releases/new-distro-release.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ assignees: lbussell
1919
1. - [ ] Update the [test data](https://github.com/dotnet/dotnet-docker/blob/nightly/tests/Microsoft.DotNet.Docker.Tests/TestData.cs) to include the new distro version
2020
1. - [ ] Update the [tags metadata templates](https://github.com/dotnet/dotnet-docker/tree/main/eng/mcr-tags-metadata-templates) to include the new distro version
2121
1. - [ ] Run the command to update the READMEs: `.\eng\readme-templates\Get-GeneratedReadmes.ps1`
22-
1. - [ ] Run the command to update the image size baseline file: `.\tests\performance\Validate-ImageSize.ps1 -UpdateBaselines`
2322
1. - [ ] Inspect generated changes for correctness
2423
1. - [ ] Consider whether sample Dockerfiles should be authored if this is a new distro and them to the [samples](https://github.com/dotnet/dotnet-docker/tree/main/samples)
2524
1. - [ ] Run the command to build and test your changes: `.build-and-test.ps1 -OS <os>`

.github/ISSUE_TEMPLATE/releases/new-windows-release.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ assignees: lbussell
1515
1. - [ ] Update the [test data](https://github.com/dotnet/dotnet-docker/blob/nightly/tests/Microsoft.DotNet.Docker.Tests/TestData.cs) to include the new Windows version
1616
1. - [ ] Update the [tags metadata templates](https://github.com/dotnet/dotnet-docker/tree/main/eng/mcr-tags-metadata-templates) to include the new Windows version
1717
1. - [ ] Run the command to update the READMEs: `.\eng\readme-templates\Get-GeneratedReadmes.ps1`
18-
1. - [ ] Run the command to update the image size baseline file: `.\tests\performance\Validate-ImageSize.ps1 -UpdateBaselines`
1918
1. - [ ] Inspect generated changes for correctness
2019
1. - [ ] Test the images
2120
1. - [ ] Create a local VM of the new Windows version

build-and-test.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ param(
2020
[string]$Mode = "BuildAndTest",
2121

2222
# Categories of tests to run
23-
[ValidateSet("runtime", "runtime-deps", "aspnet", "sdk", "pre-build", "sample", "image-size", "monitor", "aspire-dashboard")]
23+
[ValidateSet("runtime", "runtime-deps", "aspnet", "sdk", "pre-build", "sample", "monitor", "aspire-dashboard")]
2424
[string[]]$TestCategories = @("runtime", "runtime-deps", "aspnet", "sdk", "monitor", "aspire-dashboard")
2525
)
2626

eng/pipelines/dotnet-core-size-validation-pr.yml

Lines changed: 0 additions & 20 deletions
This file was deleted.

eng/pipelines/dotnet-core-size-validation.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

tests/performance/ImageSize.nightly.linux.json

Lines changed: 0 additions & 364 deletions
This file was deleted.

tests/performance/ImageSize.nightly.windows.json

Lines changed: 0 additions & 62 deletions
This file was deleted.

tests/performance/Validate-ImageSize.ps1

Lines changed: 0 additions & 68 deletions
This file was deleted.

tests/run-tests.ps1

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ param(
2828

2929
[string]$ImageInfoPath,
3030

31-
[ValidateSet("runtime", "runtime-deps", "aspnet", "sdk", "pre-build", "sample", "image-size", "monitor", "aspire-dashboard")]
31+
[ValidateSet("runtime", "runtime-deps", "aspnet", "sdk", "pre-build", "sample", "monitor", "aspire-dashboard")]
3232
[string[]]$TestCategories = @("runtime", "runtime-deps", "aspnet", "sdk", "monitor", "aspire-dashboard"),
3333

3434
[string]$CustomTestFilter,
@@ -155,10 +155,6 @@ Try {
155155

156156
Write-Host "`nRunning tests with $testFilter`n"
157157
Exec "$DotnetInstallDir/dotnet test $testFilter --logger:trx"
158-
159-
if ($TestCategories.Contains('image-size')) {
160-
& ../performance/Validate-ImageSize.ps1 -PullImages:$PullImages -ValidationMode Integrity
161-
}
162158
}
163159
Finally {
164160
Pop-Location

0 commit comments

Comments
 (0)