Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-index script potential improvements #11

Open
data-envoy opened this issue Apr 23, 2023 · 1 comment
Open

create-index script potential improvements #11

data-envoy opened this issue Apr 23, 2023 · 1 comment

Comments

@data-envoy
Copy link
Contributor

Here are some potential improvements for the script at package/scripts/create-index.ts

@dekimir can we keep this as a working document?

  • It should not index columns like id or image. Would be good if they could be exclded.
  • Accept language other than english.
  • Maybe have another index for 'simple' language for use on columns like brand name.
@dekimir
Copy link
Owner

dekimir commented Apr 26, 2023

The user should be able to include id or image columns when they want to. But it's OK to exclude them by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants