Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines changed from \n to \r\n #45

Open
cristan opened this issue Feb 3, 2025 · 5 comments
Open

Newlines changed from \n to \r\n #45

cristan opened this issue Feb 3, 2025 · 5 comments

Comments

@cristan
Copy link

cristan commented Feb 3, 2025

Ever since you started generating the dataset the new way, the newlines changed from \n to \r\n. It's not a huge problem, but I don't like it and I had to change my code to take this into account.

@gradedSystem
Copy link
Member

Does this happen in every single data we have in data/ folder ?

@cristan

@gradedSystem
Copy link
Member

@cristan I checked and it happens in every dataset in data/ folder made a fix to that

@cristan
Copy link
Author

cristan commented Feb 5, 2025

I can't test this because the dataset hasn't been generated since this has merged. And this is because the github actions fail now.

@gradedSystem
Copy link
Member

@cristan I have made PR that fixes the failed ga-action

sabas added a commit that referenced this issue Feb 6, 2025
[fix][s] Fixing github action fail - refs #45
@cristan
Copy link
Author

cristan commented Feb 6, 2025

Unfortunately, I still see \r\n in code-list.csv. Files like country-codes.csv haven't even been changed in the last 4 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants