Skip to content

Commit 5a196e2

Browse files
authored
feat: update gomark version (usememos#3679)
1 parent 9449886 commit 5a196e2

File tree

8 files changed

+177
-169
lines changed

8 files changed

+177
-169
lines changed

docs/apidocs.swagger.yaml

+4-2
Original file line numberDiff line numberDiff line change
@@ -1913,7 +1913,8 @@ definitions:
19131913
cells:
19141914
type: array
19151915
items:
1916-
type: string
1916+
type: object
1917+
$ref: '#/definitions/v1Node'
19171918
UserRole:
19181919
type: string
19191920
enum:
@@ -3045,7 +3046,8 @@ definitions:
30453046
header:
30463047
type: array
30473048
items:
3048-
type: string
3049+
type: object
3050+
$ref: '#/definitions/v1Node'
30493051
delimiter:
30503052
type: array
30513053
items:

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ require (
2525
github.com/spf13/cobra v1.8.1
2626
github.com/spf13/viper v1.19.0
2727
github.com/stretchr/testify v1.9.0
28-
github.com/usememos/gomark v0.0.0-20240630131948-9cc984646479
28+
github.com/usememos/gomark v0.0.0-20240712135956-99d0ab9b9aa1
2929
golang.org/x/crypto v0.25.0
3030
golang.org/x/mod v0.19.0
3131
golang.org/x/net v0.27.0

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,8 @@ github.com/ugorji/go v1.1.7/go.mod h1:kZn38zHttfInRq0xu/PH0az30d+z6vm202qpg1oXVM
441441
github.com/ugorji/go/codec v1.1.7/go.mod h1:Ax+UKWsSmolVDwsd+7N3ZtXu+yMGCf907BLYF3GoBXY=
442442
github.com/urfave/cli v1.20.0/go.mod h1:70zkFmudgCuE/ngEzBv17Jvp/497gISqfk5gWijbERA=
443443
github.com/urfave/cli v1.22.1/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
444-
github.com/usememos/gomark v0.0.0-20240630131948-9cc984646479 h1:Agp+J1o5z1n67uG6IKgV/fE72Io1cUF4cfwxjDqW2GY=
445-
github.com/usememos/gomark v0.0.0-20240630131948-9cc984646479/go.mod h1:7CZRoYFQyyljzplOTeyODFR26O+wr0BbnpTWVLGfKJA=
444+
github.com/usememos/gomark v0.0.0-20240712135956-99d0ab9b9aa1 h1:4LuNOC1zgAk9K8kZjTBZ/yNJR9vgQTNAQFyWxLxJp5A=
445+
github.com/usememos/gomark v0.0.0-20240712135956-99d0ab9b9aa1/go.mod h1:7CZRoYFQyyljzplOTeyODFR26O+wr0BbnpTWVLGfKJA=
446446
github.com/valyala/bytebufferpool v1.0.0 h1:GqA5TC/0021Y/b9FG4Oi9Mr3q7XYx6KllzawFIhcdPw=
447447
github.com/valyala/bytebufferpool v1.0.0/go.mod h1:6bBcMArwyJ5K/AmCkWv1jt77kVWyCJ6HpOuEn7z0Csc=
448448
github.com/valyala/fasttemplate v1.2.2 h1:lxLXG0uE3Qnshl9QyaK6XJxMXlQZELvChBOCmQD0Loo=

proto/api/v1/markdown_service.proto

+2-2
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,11 @@ message MathBlockNode {
169169
}
170170

171171
message TableNode {
172-
repeated string header = 1;
172+
repeated Node header = 1;
173173
repeated string delimiter = 2;
174174

175175
message Row {
176-
repeated string cells = 1;
176+
repeated Node cells = 1;
177177
}
178178
repeated Row rows = 3;
179179
}

proto/gen/api/v1/markdown_service.pb.go

+157-153
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

server/router/api/v1/markdown_service.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ func convertFromASTNodes(rawNodes []ast.Node) []*v1pb.Node {
133133

134134
func convertTableFromASTNode(node *ast.Table) *v1pb.TableNode {
135135
table := &v1pb.TableNode{
136-
Header: node.Header,
136+
Header: convertFromASTNodes(node.Header),
137137
Delimiter: node.Delimiter,
138138
}
139139
for _, row := range node.Rows {
140-
table.Rows = append(table.Rows, &v1pb.TableNode_Row{Cells: row})
140+
table.Rows = append(table.Rows, &v1pb.TableNode_Row{Cells: convertFromASTNodes(row)})
141141
}
142142
return table
143143
}
@@ -225,11 +225,11 @@ func convertToASTNodes(nodes []*v1pb.Node) []ast.Node {
225225

226226
func convertTableToASTNode(node *v1pb.TableNode) *ast.Table {
227227
table := &ast.Table{
228-
Header: node.Header,
228+
Header: convertToASTNodes(node.Header),
229229
Delimiter: node.Delimiter,
230230
}
231231
for _, row := range node.Rows {
232-
table.Rows = append(table.Rows, row.Cells)
232+
table.Rows = append(table.Rows, convertToASTNodes(row.Cells))
233233
}
234234
return table
235235
}

web/src/components/MemoContent/Renderer.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const Renderer: React.FC<Props> = ({ index, node }: Props) => {
8686
case NodeType.MATH_BLOCK:
8787
return <Math {...(node.mathBlockNode as MathBlockNode)} block={true} />;
8888
case NodeType.TABLE:
89-
return <Table {...(node.tableNode as TableNode)} />;
89+
return <Table index={index} {...(node.tableNode as TableNode)} />;
9090
case NodeType.EMBEDDED_CONTENT:
9191
return <EmbeddedContent {...(node.embeddedContentNode as EmbeddedContentNode)} />;
9292
case NodeType.TEXT:

web/src/components/MemoContent/Table.tsx

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
import { TableNode_Row } from "@/types/proto/api/v1/markdown_service";
1+
import { Node, TableNode_Row } from "@/types/proto/api/v1/markdown_service";
2+
import Renderer from "./Renderer";
23

34
interface Props {
4-
header: string[];
5+
index: string;
6+
header: Node[];
57
rows: TableNode_Row[];
68
}
79

@@ -12,7 +14,7 @@ const Table = ({ header, rows }: Props) => {
1214
<tr className="divide-x divide-gray-300 dark:divide-zinc-600">
1315
{header.map((h, i) => (
1416
<th key={i} className="py-1 px-2">
15-
{h}
17+
<Renderer key={`${h.type}-${i}`} index={String(i)} node={h} />
1618
</th>
1719
))}
1820
</tr>
@@ -22,7 +24,7 @@ const Table = ({ header, rows }: Props) => {
2224
<tr key={i} className="divide-x divide-gray-300 dark:divide-zinc-600">
2325
{row.cells.map((r, j) => (
2426
<td key={j} className="py-1 px-2">
25-
{r}
27+
<Renderer key={`${r.type}-${i}-${j}`} index={String(j)} node={r} />
2628
</td>
2729
))}
2830
</tr>

0 commit comments

Comments
 (0)