Skip to content

Commit 1e540d2

Browse files
committed
Fix GC failure of CRI plugin
Signed-off-by: Kohei Tokunaga <[email protected]>
1 parent 1c4bf94 commit 1e540d2

File tree

7 files changed

+22
-1
lines changed

7 files changed

+22
-1
lines changed

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,17 @@ version = 2
6262
[proxy_plugins.stargz]
6363
type = "snapshot"
6464
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
65+
[proxy_plugins.stargz.exports]
66+
root = "/var/lib/containerd-stargz-grpc/"
6567

6668
# Use stargz snapshotter through CRI
6769
[plugins."io.containerd.grpc.v1.cri".containerd]
6870
snapshotter = "stargz"
6971
disable_snapshot_annotations = false
7072
```
7173

72-
**Note that `disable_snapshot_annotations = false` is required since containerd > v1.4.2**
74+
> NOTE1: `disable_snapshot_annotations = false` is required since containerd > v1.4.2
75+
> NOTE2: `root` field of `proxy_plugins` requires containerd >= v1.6.32 or v1.7.16 or v2.0.0
7376
7477
You can try our [prebuilt](/Dockerfile) [KinD](https://github.com/kubernetes-sigs/kind) node image that contains the above configuration.
7578

docs/INSTALL.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,13 @@ We assume that you are using containerd (> v1.4.2) as a CRI runtime.
4444
[proxy_plugins.stargz]
4545
type = "snapshot"
4646
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
47+
[proxy_plugins.stargz.exports]
48+
root = "/var/lib/containerd-stargz-grpc/"
4749

4850
```
4951

52+
> NOTE: `root` field of `proxy_plugins` requires containerd >= v1.6.32 or v1.7.16 or v2.0.0
53+
5054
- Install fuse
5155

5256
###### centos
@@ -145,6 +149,8 @@ We assume that you are using CRI-O newer than https://github.com/cri-o/cri-o/pul
145149
[proxy_plugins.stargz]
146150
type = "snapshot"
147151
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
152+
[proxy_plugins.stargz.exports]
153+
root = "/var/lib/containerd-stargz-grpc/"
148154
```
149155

150156
- Install fuse

docs/overview.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,17 @@ version = 2
4444
[proxy_plugins.stargz]
4545
type = "snapshot"
4646
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
47+
[proxy_plugins.stargz.exports]
48+
root = "/var/lib/containerd-stargz-grpc/"
4749

4850
# Use stargz snapshotter through CRI
4951
[plugins."io.containerd.grpc.v1.cri".containerd]
5052
snapshotter = "stargz"
5153
disable_snapshot_annotations = false
5254
```
5355

56+
> NOTE: `root` field of `proxy_plugins` requires containerd >= v1.6.32 or v1.7.16 or v2.0.0
57+
5458
This repo contains [a Dockerfile as a KinD node image](/Dockerfile) which includes the above configuration.
5559

5660
## State directory

script/benchmark/config-containerd/etc/containerd/config.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@ version = 2
44
[proxy_plugins.stargz]
55
type = "snapshot"
66
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
7+
[proxy_plugins.stargz.exports]
8+
root = "/var/lib/containerd-stargz-grpc/"

script/config/etc/containerd/config.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,5 @@ version = 2
2222
[proxy_plugins.stargz]
2323
type = "snapshot"
2424
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
25+
[proxy_plugins.stargz.exports]
26+
root = "/var/lib/containerd-stargz-grpc/"

script/demo/config.containerd.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@ version = 2
44
[proxy_plugins.stargz]
55
type = "snapshot"
66
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
7+
[proxy_plugins.stargz.exports]
8+
root = "/var/lib/containerd-stargz-grpc/"

script/integration/containerd/entrypoint.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,8 @@ if [ "${BUILTIN_SNAPSHOTTER}" != "true" ] ; then
243243
[proxy_plugins.stargz]
244244
type = "snapshot"
245245
address = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
246+
[proxy_plugins.stargz.exports]
247+
root = "/var/lib/containerd-stargz-grpc/"
246248
EOF
247249
fi
248250

0 commit comments

Comments
 (0)