Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example.javalib.__.native.server.test CI job doesn't seem to be benefiting from selective testing #4343

Open
lihaoyi opened this issue Jan 16, 2025 · 3 comments

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Jan 16, 2025

Every other job seems to benefit, we need to investigate and figure out why this one does not

lihaoyi added a commit that referenced this issue Jan 17, 2025
…sbehaviors (#4349)

Also lots of general refactoring for the
SelectiveExecution/SpanningForest logic

I need this myself to help debug
#4343
lihaoyi added a commit that referenced this issue Jan 17, 2025
Hopefully this will give us some hints as to why
#4343 is happening
@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 17, 2025

Here's the selective.resolveTree:

https://github.com/com-lihaoyi/mill/actions/runs/12829005900/job/35774467241?pr=4355

{
  "dist.native.executableRaw": {
    "dist.native.executable": {
      "example.javalib.migrating[2-maven-incomplete].native.millIntegrationLauncher": {
        "example.javalib.migrating[2-maven-incomplete].native.server.forkEnv": {
          "example.javalib.migrating[2-maven-incomplete].native.server.test": {}
        }
      },
      "example.javalib.web[4-hello-micronaut].native.millIntegrationLauncher": {
        "example.javalib.web[4-hello-micronaut].native.server.forkEnv": {
          "example.javalib.web[4-hello-micronaut].native.server.test": {}
        }
      },
      "example.javalib.basic[4-compat-modules].native.millIntegrationLauncher": {
        "example.javalib.basic[4-compat-modules].native.server.forkEnv": {
          "example.javalib.basic[4-compat-modules].native.server.test": {}
        }
      },
      "example.javalib.dependencies[1-ivy-deps].native.millIntegrationLauncher": {
        "example.javalib.dependencies[1-ivy-deps].native.server.forkEnv": {
          "example.javalib.dependencies[1-ivy-deps].native.server.test": {}
        }
      },
      "example.javalib.dependencies[2-run-compile-deps].native.millIntegrationLauncher": {
        "example.javalib.dependencies[2-run-compile-deps].native.server.forkEnv": {
          "example.javalib.dependencies[2-run-compile-deps].native.server.test": {}
        }
      },
      "example.javalib.module[1-common-config].native.millIntegrationLauncher": {
        "example.javalib.module[1-common-config].native.server.forkEnv": {
          "example.javalib.module[1-common-config].native.server.test": {}
        }
      },
      "example.javalib.dependencies[5-repository-config].native.millIntegrationLauncher": {
        "example.javalib.dependencies[5-repository-config].native.server.forkEnv": {
          "example.javalib.dependencies[5-repository-config].native.server.test": {}
        }
      },
      "example.javalib.publishing[5-jlink].native.millIntegrationLauncher": {
        "example.javalib.publishing[5-jlink].native.server.forkEnv": {
          "example.javalib.publishing[5-jlink].native.server.test": {}
        }
      },
      "example.javalib.dependencies[3-unmanaged-jars].native.millIntegrationLauncher": {
        "example.javalib.dependencies[3-unmanaged-jars].native.server.forkEnv": {
          "example.javalib.dependencies[3-unmanaged-jars].native.server.test": {}
        }
      },
      "example.javalib.testing[2-test-deps].native.millIntegrationLauncher": {
        "example.javalib.testing[2-test-deps].native.server.forkEnv": {
          "example.javalib.testing[2-test-deps].native.server.test": {}
        }
      },
      "example.javalib.dependencies[4-downloading-unmanaged-jars].native.millIntegrationLauncher": {
        "example.javalib.dependencies[4-downloading-unmanaged-jars].native.server.forkEnv": {
          "example.javalib.dependencies[4-downloading-unmanaged-jars].native.server.test": {}
        }
      },
      "example.javalib.testing[1-test-suite].native.millIntegrationLauncher": {
        "example.javalib.testing[1-test-suite].native.server.forkEnv": {
          "example.javalib.testing[1-test-suite].native.server.test": {}
        }
      },
      "example.javalib.basic[2-custom-build-logic].native.millIntegrationLauncher": {
        "example.javalib.basic[2-custom-build-logic].native.server.forkEnv": {
          "example.javalib.basic[2-custom-build-logic].native.server.test": {}
        }
      },
      "example.javalib.module[[15](https://github.com/com-lihaoyi/mill/actions/runs/12829005900/job/35774467241?pr=4355#step:12:16)-jni].native.millIntegrationLauncher": {
        "example.javalib.module[15-jni].native.server.forkEnv": {
          "example.javalib.module[15-jni].native.server.test": {}
        }
      },
      "example.javalib.testing[4-test-grouping].native.millIntegrationLauncher": {
        "example.javalib.testing[4-test-grouping].native.server.forkEnv": {
          "example.javalib.testing[4-test-grouping].native.server.test": {}
        }
      },
      "example.javalib.module[2-custom-tasks].native.millIntegrationLauncher": {
        "example.javalib.module[2-custom-tasks].native.server.forkEnv": {
          "example.javalib.module[2-custom-tasks].native.server.test": {}
        }
      },
      "example.javalib.migrating[1-maven-complete].native.millIntegrationLauncher": {
        "example.javalib.migrating[1-maven-complete].native.server.forkEnv": {
          "example.javalib.migrating[1-maven-complete].native.server.test": {}
        }
      },
      "example.javalib.linting[1-error-prone].native.millIntegrationLauncher": {
        "example.javalib.linting[1-error-prone].native.server.forkEnv": {
          "example.javalib.linting[1-error-prone].native.server.test": {}
        }
      },
      "example.javalib.publishing[3-revapi].native.millIntegrationLauncher": {
        "example.javalib.publishing[3-revapi].native.server.forkEnv": {
          "example.javalib.publishing[3-revapi].native.server.test": {}
        }
      },
      "example.javalib.linting[2-checkstyle].native.millIntegrationLauncher": {
        "example.javalib.linting[2-checkstyle].native.server.forkEnv": {
          "example.javalib.linting[2-checkstyle].native.server.test": {}
        }
      }
    }
  }
}

Not sure why dist.native.executableRaw is triggering selective execution of downstream tests, but that at least explains why it only happens for the .native version of the tests and not .packaged or .local

@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 18, 2025

The new selective.resolveChanged command has confirmed that dist.native.executableRaw is the invalidation root. The question remains why it can be one when neither the code nor the build config has changed

@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 18, 2025

Seems to be specific to our multi-stage CI process with separate build and test jobs; doesn't happen when the selective execution logic is run on a single machine https://github.com/com-lihaoyi/mill/actions/runs/12839331167/job/35806439311?pr=4357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant