Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License set as Declared is not in the package #519

Open
capfei opened this issue Apr 12, 2023 · 2 comments
Open

License set as Declared is not in the package #519

capfei opened this issue Apr 12, 2023 · 2 comments

Comments

@capfei
Copy link
Member

capfei commented Apr 12, 2023

https://clearlydefined.io/definitions/pypi/pypi/-/pillow/9.5.0

After harvesting pypi/pypi/-/pillow/9.5.0 yesterday, it came back with CAL-1.0 as the declared license but I could not find this anywhere in the harvested data.
image

I checked the previous version, 9.4.0, it looks like it also back as CAL-1.0 in the harvested data.
https://clearlydefined.io/definitions/pypi/pypi/-/pillow/9.4.0

@qtomlinson
Copy link
Collaborator

qtomlinson commented Nov 2, 2023

There are two problems identified by this issue:

  1. extracting declared license in pypiFetch,
  • the license is extracted from classifiers (in the registry data) first. in _extractLicenseFromClassifiers, spdxCorrect("Historical Permission Notice and Disclaimer (HPND)") returns CAL-1.0.
  • if info.license (HPND) in the registry data is used to extract the license first instead, the resulting license from spdxCorrect("HPND") would be correct. This is related to the discussion
  1. scancode summarizer (in service) should pick up the declared license detected in scancode raw data.

@qtomlinson
Copy link
Collaborator

  1. scancode summarizer (in service) should pick up the declared license detected in scancode raw data.

This has been fixed by Commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants