-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX/ScriptNode] Chain node -> Wrap into DSP network: filename should be the trimmed Name string, not the chain node id #607
Comments
hmm, that would involve writing the name property back to the ID string, handling all errors with whitespace and other invalid IDs alongside the horrors of making sure that changing the ID does not fuck up all cable connections that we are so happy to have put behind us with the BTW in which workflow do you use that function? I've not used it in a few years now and maybe I've added new features that makes the entire process obsolete. |
I create mini-networks inside of a network, realize I will have to use it in 5 other places, then decide to put it into a separate network. I mean what I describe in the post can be done with a post-batch script: store the name of the network, remove and invalid filenaming characters and trim whitespace, change the network filename, change network ID on line 3, change node ID on line 4. Because that's what I do now manually. |
I haven't. Good stuff, works great. I have some cases where I want the changes propagated but this will make sharing networks between projects a lot easier. It even uses the name property to create the file (so obviously it works here). However, there's a big UX issue with it: it will replace an existing template of the same name without prompting. This can be nasty. |
This was probably missed when the name property was introduced.
When wrapping a chain into a DSP network, the id of the chain node (now unchangeable) gets picked up as the filename. Now your network is named chain8.xml, and you gotta go rename the file, and change up all the IDs in the file (in 3 places, otherwise the red screen of death pops up on network load).
The text was updated successfully, but these errors were encountered: