Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The way the creds parameter is used is undocumented #422

Closed
SamStephens opened this issue Nov 22, 2023 · 1 comment
Closed

The way the creds parameter is used is undocumented #422

SamStephens opened this issue Nov 22, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@SamStephens
Copy link
Contributor

SamStephens commented Nov 22, 2023 •
edited
Loading

The creds attribute of IImageName is used to look up secrets to provide credentials is undocumented and confusing at first use.

I note that they are documented in the actual source, but not in API.md.
@SamStephens SamStephens mentioned this issue Nov 22, 2023
Closed
@mrgrain mrgrain added the documentation Improvements or additions to documentation label Oct 16, 2024
@mrgrain
Copy link
Contributor

mrgrain commented Mar 13, 2025 •
edited
Loading

This has been fixed: https://github.com/cdklabs/cdk-ecr-deployment/blob/main/API.md#iimagename-

@mrgrain mrgrain closed this as completed Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrgrain @SamStephens