Skip to content

Commit 0b246ce

Browse files
Disable sensor publish feature for secure tunnel builds (#300)
* Disable sensor publish feature for secure tunnel builds * Disable feature flag check * Just skip tests * Flip preprocessor
1 parent d633b0a commit 0b246ce

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

.github/build.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ cd ./build/
103103
case $compileMode in
104104
st_component_mode)
105105
echo "Building in ST component mode"
106-
cmake ../ -DCMAKE_BUILD_TYPE=MinSizeRel -DBUILD_SDK=ON -DBUILD_TEST_DEPS=OFF -DLINK_DL=ON -DEXCLUDE_JOBS=ON -DEXCLUDE_DD=ON -DEXCLUDE_FP=ON -DDISABLE_MQTT=ON
106+
cmake ../ -DCMAKE_BUILD_TYPE=MinSizeRel -DBUILD_SDK=ON -DBUILD_TEST_DEPS=OFF -DLINK_DL=ON -DEXCLUDE_JOBS=ON -DEXCLUDE_DD=ON -DEXCLUDE_FP=ON -DDISABLE_MQTT=ON -DEXCLUDE_SENSOR_PUBLISH=ON
107107
;;
108108
armhf_cross_mode)
109109
apt-get update
@@ -125,7 +125,7 @@ case $compileMode in
125125
cd ..
126126
if [ "$stMode" = true ]; then
127127
# Set CMake flags for ST mode
128-
cmake -DCMAKE_BUILD_TYPE=RELEASE -DCMAKE_TOOLCHAIN_FILE=../cmake-toolchain/Toolchain-armhf.cmake -DBUILD_SDK=ON -DEXCLUDE_JOBS=ON -DEXCLUDE_DD=ON -DEXCLUDE_FP=ON -DDISABLE_MQTT=ON ../
128+
cmake -DCMAKE_BUILD_TYPE=RELEASE -DCMAKE_TOOLCHAIN_FILE=../cmake-toolchain/Toolchain-armhf.cmake -DBUILD_SDK=ON -DEXCLUDE_JOBS=ON -DEXCLUDE_DD=ON -DEXCLUDE_FP=ON -DDISABLE_MQTT=ON -DEXCLUDE_SENSOR_PUBLISH=ON ../
129129
elif [ "$sharedLibs" = true ]; then
130130
cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=RELEASE -DCMAKE_TOOLCHAIN_FILE=../cmake-toolchain/Toolchain-armhf.cmake -DBUILD_SDK=ON ../
131131
make install DESTDIR=./shared_install_dir
@@ -188,7 +188,7 @@ case $compileMode in
188188
cd ..
189189
if [ "$stMode" = true ]; then
190190
# Set CMake flags for ST mode
191-
cmake -DCMAKE_BUILD_TYPE=MinSizeRel -DCMAKE_TOOLCHAIN_FILE=../cmake-toolchain/Toolchain-aarch64.cmake -DBUILD_SDK=ON -DEXCLUDE_JOBS=ON -DEXCLUDE_DD=ON -DEXCLUDE_FP=ON -DDISABLE_MQTT=ON ../
191+
cmake -DCMAKE_BUILD_TYPE=MinSizeRel -DCMAKE_TOOLCHAIN_FILE=../cmake-toolchain/Toolchain-aarch64.cmake -DBUILD_SDK=ON -DEXCLUDE_JOBS=ON -DEXCLUDE_DD=ON -DEXCLUDE_FP=ON -DDISABLE_MQTT=ON -DEXCLUDE_SENSOR_PUBLISH=ON ../
192192
elif [ "$sharedLibs" = true ]; then
193193
cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=MinSizeRel -DCMAKE_TOOLCHAIN_FILE=../cmake-toolchain/Toolchain-aarch64.cmake -DBUILD_SDK=ON ../
194194
make install DESTDIR=./shared_install_dir

test/config/TestConfig.cpp

+21
Original file line numberDiff line numberDiff line change
@@ -1258,6 +1258,9 @@ TEST_F(ConfigTestFixture, SensorPublishInvalidConfigAddr)
12581258
PlainConfig config;
12591259
config.LoadFromJson(jsonView);
12601260

1261+
#if defined(EXCLUDE_SENSOR_PUBLISH)
1262+
GTEST_SKIP();
1263+
#endif
12611264
ASSERT_FALSE(config.Validate()); // Invalid permissions on addr.
12621265
ASSERT_TRUE(config.sensorPublish.enabled);
12631266
ASSERT_EQ(config.sensorPublish.settings.size(), 1);
@@ -1290,6 +1293,9 @@ TEST_F(ConfigTestFixture, SensorPublishInvalidConfigMqttTopicEmpty)
12901293
PlainConfig config;
12911294
config.LoadFromJson(jsonView);
12921295

1296+
#if defined(EXCLUDE_SENSOR_PUBLISH)
1297+
GTEST_SKIP();
1298+
#endif
12931299
ASSERT_FALSE(config.Validate()); // Empty mqtt_topic.
12941300
ASSERT_TRUE(config.sensorPublish.enabled);
12951301
ASSERT_EQ(config.sensorPublish.settings.size(), 1);
@@ -1322,6 +1328,9 @@ TEST_F(ConfigTestFixture, SensorPublishInvalidConfigMqttTopic)
13221328
PlainConfig config;
13231329
config.LoadFromJson(jsonView);
13241330

1331+
#if defined(EXCLUDE_SENSOR_PUBLISH)
1332+
GTEST_SKIP();
1333+
#endif
13251334
ASSERT_FALSE(config.Validate()); // Invalid mqtt_topic.
13261335
ASSERT_TRUE(config.sensorPublish.enabled);
13271336
ASSERT_EQ(config.sensorPublish.settings.size(), 1);
@@ -1354,6 +1363,9 @@ TEST_F(ConfigTestFixture, SensorPublishInvalidConfigEomDelimiter)
13541363
PlainConfig config;
13551364
config.LoadFromJson(jsonView);
13561365

1366+
#if defined(EXCLUDE_SENSOR_PUBLISH)
1367+
GTEST_SKIP();
1368+
#endif
13571369
ASSERT_FALSE(config.Validate()); // Invalid eom_delimiter.
13581370
ASSERT_TRUE(config.sensorPublish.enabled);
13591371
ASSERT_EQ(config.sensorPublish.settings.size(), 1);
@@ -1390,6 +1402,9 @@ TEST_F(ConfigTestFixture, SensorPublishInvalidConfigNegativeIntegers)
13901402
PlainConfig config;
13911403
config.LoadFromJson(jsonView);
13921404

1405+
#if defined(EXCLUDE_SENSOR_PUBLISH)
1406+
GTEST_SKIP();
1407+
#endif
13931408
ASSERT_FALSE(config.Validate()); // Invalid integer values.
13941409
ASSERT_TRUE(config.sensorPublish.enabled);
13951410
ASSERT_EQ(config.sensorPublish.settings.size(), 1);
@@ -1423,6 +1438,9 @@ TEST_F(ConfigTestFixture, SensorPublishInvalidConfigBufferCapacityTooSmall)
14231438
PlainConfig config;
14241439
config.LoadFromJson(jsonView);
14251440

1441+
#if defined(EXCLUDE_SENSOR_PUBLISH)
1442+
GTEST_SKIP();
1443+
#endif
14261444
ASSERT_FALSE(config.Validate()); // Buffer capacity too small.
14271445
ASSERT_TRUE(config.sensorPublish.enabled);
14281446
ASSERT_EQ(config.sensorPublish.settings.size(), 1);
@@ -1456,6 +1474,9 @@ TEST_F(ConfigTestFixture, SensorPublishDisableFeature)
14561474
PlainConfig config;
14571475
config.LoadFromJson(jsonView);
14581476

1477+
#if defined(EXCLUDE_SENSOR_PUBLISH)
1478+
GTEST_SKIP();
1479+
#endif
14591480
ASSERT_FALSE(config.Validate()); // All sensors disabled, then disable feature.
14601481
ASSERT_FALSE(config.sensorPublish.enabled);
14611482
ASSERT_EQ(config.sensorPublish.settings.size(), 1);

0 commit comments

Comments
 (0)