Skip to content

Add option to crawlee cli to install the project or not #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pijukatel opened this issue Mar 28, 2025 · 3 comments
Open

Add option to crawlee cli to install the project or not #1122

Pijukatel opened this issue Mar 28, 2025 · 3 comments
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Milestone

Comments

@Pijukatel
Copy link
Collaborator

Pijukatel commented Mar 28, 2025

Currently there are following options for package manager when running crawlee cli:
Poetry
Pip
Uv
Manual

Selecting any of the options except for the manual will not only prepare the project files, but immediately also install the packages to whatever environment is currently active, which might not be desired. (What is the use case where this is actually desired?)

Add one more boolean cli option "install the project to current environment" which will follow after package manager selection and will control whether the post_gen hook installs the project or not.

(Maybe drop the manual option?)

@Pijukatel Pijukatel added enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team. labels Mar 28, 2025
@Pijukatel Pijukatel changed the title Add option to apify cli to install the project or not Add option to crawlee cli to install the project or not Mar 28, 2025
@janbuchar
Copy link
Collaborator

Selecting any of the options except for the manual will not only prepare the project files, but immediately also install the packages to whatever environment is currently active, which might not be desired. (What is the use case where this is actually desired?)

Um, starting a new project? Installing dependencies is the next step after bootstrapping for most users - it is comfortable if we do it for them.

Add one more boolean cli option "install the project to current environment" which will follow after package manager selection and will control whether the post_gen hook installs the project or not.

(Maybe drop the manual option?)

Yeah, dropping that option sounds like a good idea.

@vdusek
Copy link
Collaborator

vdusek commented Mar 28, 2025

Add one more boolean cli option "install the project to current environment" which will follow after package manager selection and will control whether the post_gen hook installs the project or not.

👍

@Pijukatel
Copy link
Collaborator Author

Um, starting a new project? Installing dependencies is the next step after bootstrapping for most users - it is comfortable if we do it for them.

Yes, I agree it is useful to install the dependencies for the users, I am just questioning the part about installing it to the currently active environment.

I would be also happy if this is just solved by installing the project automatically, but to dedicated freshly created environment.

@B4nan B4nan added this to the 1.0 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

4 participants