Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Go target (and likely Cpp target) not robust because "antlr4" tool doesn't work reliably. #3514

Closed
kaby76 opened this issue Jun 6, 2023 · 0 comments · Fixed by #3515

Comments

@kaby76
Copy link
Contributor

kaby76 commented Jun 6, 2023

As I pointed out here, the "antlr4" tool is not reliable if one tries to just use the "latest" version of Antlr, i.e., don't use the -v option to say what version you want. It looks like the query times out and then the code crashes. This is catastrophic for testing. And, programming around this by detecting this particular crash, as opposed to a legitimate problem with the grammar you are trying to run the tool on, would not be very nice looking scripting code. Already these Bash scripts look like a mess.

We'll need to set the version explicitly for the Go (and likely Cpp) target.

teverett pushed a commit that referenced this issue Jun 7, 2023
* Fix for #3514

This change brings back the explicit version tags for Antlr to Cpp and Go targets, avoiding the problem with the "antlr4" Python script.

* Fix the Pwsh version for the Go template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants