Fixed exact cosine distance for OpenSearch 2.19+

ankane · ankane · commit 74db753b3a58 · 2025-04-01T19:11:33.000-07:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -23,7 +23,7 @@ jobs:
             elasticsearch: 7.17.22
           - ruby: 3.3
             gemfile: gemfiles/opensearch3.gemfile
-            opensearch: 2.16.0
+            opensearch: 2.19.1
           - ruby: 3.2
             gemfile: gemfiles/opensearch2.gemfile
             opensearch: 2.0.0
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 5.4.1 (unreleased)
+
+- Fixed exact cosine distance for OpenSearch 2.19+
+
 ## 5.4.0 (2024-09-04)
 
 - Added `knn` option
diff --git a/lib/searchkick/query.rb b/lib/searchkick/query.rb
@@ -934,7 +934,7 @@ def set_knn(payload, knn, per_page, offset)
                   space_type: space_type
                 }
               },
-              boost: distance == "cosine" ? 0.5 : 1.0
+              boost: distance == "cosine" && Searchkick.server_below?("2.19.0", true) ? 0.5 : 1.0
             }
           }
         else

Original file line number	Diff line number	Diff line change
`@@ -934,7 +934,7 @@ def set_knn(payload, knn, per_page, offset)`
`934`	`934`	`space_type: space_type`
`935`	`935`	`}`
`936`	`936`	`},`
`937`		`- boost: distance == "cosine" ? 0.5 : 1.0`
	`937`	`+ boost: distance == "cosine" && Searchkick.server_below?("2.19.0", true) ? 0.5 : 1.0`
`938`	`938`	`}`
`939`	`939`	`}`
`940`	`940`	`else`