Skip to content

Commit 5711e3d

Browse files
authored
ci(node): remove eol node versions
This also fixes the tests on windows, which are currently broken in the main branch
1 parent 2d19ea9 commit 5711e3d

6 files changed

+7
-7
lines changed

.github/workflows/health-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
tests:
1010
strategy:
1111
matrix:
12-
node: [ '14.x', '16.x', '18.x', '20.x', '22.x' ]
12+
node: [ '18.x', '20.x', '22.x' ]
1313
os: [ ubuntu-latest, windows-latest, macos-latest ]
1414
runs-on: ${{ matrix.os }}
1515
name: Node ${{ matrix.node }} - ${{ matrix.os }}

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
tests:
1010
strategy:
1111
matrix:
12-
node: [ '14.x', '16.x', '18.x', '20.x', '22.x' ]
12+
node: [ '18.x', '20.x', '22.x' ]
1313
os: [ ubuntu-latest, windows-latest, macos-latest ]
1414
runs-on: ${{ matrix.os }}
1515
name: Node ${{ matrix.node }} - ${{ matrix.os }}

__tests__/outdated-snapshot-reporter.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ describe('OutdatedSnapshotReporter', () => {
6161
cwd: tmpDir,
6262
encoding: 'utf-8',
6363
env: { ...process.env, ...environment },
64+
shell: true,
6465
});
6566
if (child.error) throw child.error;
6667

package-lock.json

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"eslint-config-amex": "^7.0.0",
5454
"husky": "^4.2.1",
5555
"image-size": "^0.8.3",
56-
"jest": "^29.0.0",
56+
"jest": "^29.7.0",
5757
"jest-snapshot": "^29.0.0",
5858
"lockfile-lint": "^4.14.0",
5959
"mock-spawn": "^0.2.6",
@@ -106,9 +106,9 @@
106106
"@semantic-release/git",
107107
"@semantic-release/github"
108108
]
109-
},
109+
},
110110
"overrides": {
111-
"eslint-config-amex" : {
111+
"eslint-config-amex": {
112112
"eslint": "$eslint"
113113
}
114114
}

0 commit comments

Comments
 (0)