Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builder] Builder UO reject should remove expected storage slots #985

Open
dancoombs opened this issue Jan 30, 2025 · 0 comments
Open

[builder] Builder UO reject should remove expected storage slots #985

dancoombs opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dancoombs
Copy link
Collaborator

Describe the bug
The bundle builder calls assemble_context where it:

  1. Calculates the bundle gas limit - but only to limit the total size
  2. Collects expected storage slots
  3. Computes aggregated signatures

It then calls estimate_gas_rejecting_failed_ops, calculating an exact gas limit. If it rejects any UOs it also recalculates any associated aggregated signatures. However, it misses removing that rejected UOs storage slots. In both the fitler_reject and reject_index we should remove the expected storage slots of rejected entities (potentially look at some more code sharing/cleanup here).

@dancoombs dancoombs added bug Something isn't working needs-triage Issue needs triage labels Jan 30, 2025
@dancoombs dancoombs added this to the v0.6 milestone Jan 30, 2025
@dancoombs dancoombs self-assigned this Jan 30, 2025
@dancoombs dancoombs changed the title [builder] Builder UO reject should rmove expected storage slots [builder] Builder UO reject should remove expected storage slots Jan 30, 2025
@dancoombs dancoombs removed the needs-triage Issue needs triage label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant