You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The bundle builder calls assemble_context where it:
Calculates the bundle gas limit - but only to limit the total size
Collects expected storage slots
Computes aggregated signatures
It then calls estimate_gas_rejecting_failed_ops, calculating an exact gas limit. If it rejects any UOs it also recalculates any associated aggregated signatures. However, it misses removing that rejected UOs storage slots. In both the fitler_reject and reject_index we should remove the expected storage slots of rejected entities (potentially look at some more code sharing/cleanup here).
The text was updated successfully, but these errors were encountered:
dancoombs
changed the title
[builder] Builder UO reject should rmove expected storage slots
[builder] Builder UO reject should remove expected storage slots
Jan 30, 2025
Describe the bug
The bundle builder calls
assemble_context
where it:It then calls
estimate_gas_rejecting_failed_ops
, calculating an exact gas limit. If it rejects any UOs it also recalculates any associated aggregated signatures. However, it misses removing that rejected UOs storage slots. In both thefitler_reject
andreject_index
we should remove the expected storage slots of rejected entities (potentially look at some more code sharing/cleanup here).The text was updated successfully, but these errors were encountered: