Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on how to use within a route #114

Open
lukemelia opened this issue Apr 21, 2020 · 2 comments
Open

Improve documentation on how to use within a route #114

lukemelia opened this issue Apr 21, 2020 · 2 comments

Comments

@lukemelia
Copy link
Collaborator

Quick version: set keyboardActivated to true in the route's activate hook and to false in the deactivate hook.

See #52 for some more discussion.

@SergeAstapov
Copy link
Contributor

I think with latest changes in the addon this is invalid approach and the one can use on-key helper like so

{{on-key '/' this.onSlash}}

Such approach is already being taught in docs on Usage page.

@lukemelia what do you think? Should we close this?

@wagenet
Copy link
Contributor

wagenet commented Oct 12, 2023

For future reference: If you define the handlers on the route class and use the @keyResponder decorator, you'll want to do @keyResponder({ activated: false }) and then toggle keyboardActivated on activate and deactivate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants