Skip to content

Commit 7d87029

Browse files
committed
add qt5 tests in addition to qt4 tests
1 parent 588dbaa commit 7d87029

File tree

72 files changed

+190
-84
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+190
-84
lines changed

tests/Makefile.am

Lines changed: 54 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -133,30 +133,58 @@ TESTS = \
133133

134134
if COMPILE_LIBLIGHTDM_QT4
135135
TESTS += \
136-
test-autologin-qt-timeout \
137-
test-autologin-qt-guest-timeout \
138-
test-login-qt \
139-
test-login-qt-manual \
140-
test-login-qt-manual-previous-session \
141-
test-login-qt-no-password \
142-
test-login-qt-long-username \
143-
test-login-qt-long-password \
144-
test-login-qt-two-factor \
145-
test-login-qt-new-authtok \
146-
test-login-qt-info-prompt \
147-
test-login-qt-multi-info-prompt \
148-
test-login-qt-previous-session \
149-
test-login-qt-wrong-password \
150-
test-login-qt-invalid-user \
151-
test-login-qt-invalid-session \
152-
test-login-qt-logout \
153-
test-login-qt-pick-session \
154-
test-login-qt-guest \
155-
test-login-qt-guest-disabled \
156-
test-login-qt-guest-no-setup-script \
157-
test-login-qt-guest-fail-setup-script \
158-
test-login-qt-guest-logout \
159-
test-login-qt-remote-session
136+
test-autologin-qt4-timeout \
137+
test-autologin-qt4-guest-timeout \
138+
test-login-qt4 \
139+
test-login-qt4-manual \
140+
test-login-qt4-manual-previous-session \
141+
test-login-qt4-no-password \
142+
test-login-qt4-long-username \
143+
test-login-qt4-long-password \
144+
test-login-qt4-two-factor \
145+
test-login-qt4-new-authtok \
146+
test-login-qt4-info-prompt \
147+
test-login-qt4-multi-info-prompt \
148+
test-login-qt4-previous-session \
149+
test-login-qt4-wrong-password \
150+
test-login-qt4-invalid-user \
151+
test-login-qt4-invalid-session \
152+
test-login-qt4-logout \
153+
test-login-qt4-pick-session \
154+
test-login-qt4-guest \
155+
test-login-qt4-guest-disabled \
156+
test-login-qt4-guest-no-setup-script \
157+
test-login-qt4-guest-fail-setup-script \
158+
test-login-qt4-guest-logout \
159+
test-login-qt4-remote-session
160+
endif
161+
162+
if COMPILE_LIBLIGHTDM_QT5
163+
TESTS += \
164+
test-autologin-qt5-timeout \
165+
test-autologin-qt5-guest-timeout \
166+
test-login-qt5 \
167+
test-login-qt5-manual \
168+
test-login-qt5-manual-previous-session \
169+
test-login-qt5-no-password \
170+
test-login-qt5-long-username \
171+
test-login-qt5-long-password \
172+
test-login-qt5-two-factor \
173+
test-login-qt5-new-authtok \
174+
test-login-qt5-info-prompt \
175+
test-login-qt5-multi-info-prompt \
176+
test-login-qt5-previous-session \
177+
test-login-qt5-wrong-password \
178+
test-login-qt5-invalid-user \
179+
test-login-qt5-invalid-session \
180+
test-login-qt5-logout \
181+
test-login-qt5-pick-session \
182+
test-login-qt5-guest \
183+
test-login-qt5-guest-disabled \
184+
test-login-qt5-guest-no-setup-script \
185+
test-login-qt5-guest-fail-setup-script \
186+
test-login-qt5-guest-logout \
187+
test-login-qt5-remote-session
160188
endif
161189

162190
EXTRA_DIST = \
@@ -166,7 +194,8 @@ EXTRA_DIST = \
166194
data/session.conf \
167195
data/xgreeters/test-gobject-greeter.desktop \
168196
data/xgreeters/test-python-greeter.desktop \
169-
data/xgreeters/test-qt-greeter.desktop \
197+
data/xgreeters/test-qt4-greeter.desktop \
198+
data/xgreeters/test-qt5-greeter.desktop \
170199
data/xsessions/alternative.desktop \
171200
data/xsessions/default.desktop \
172201
scripts/autologin.conf \

tests/data/xgreeters/test-qt-greeter.desktop

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[Desktop Entry]
2+
Name=Test Qt4 Greeter
3+
Comment=LightDM test Qt4 greeter
4+
Exec=test-qt4-greeter
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[Desktop Entry]
2+
Name=Test Qt5 Greeter
3+
Comment=LightDM test Qt5 greeter
4+
Exec=test-qt5-greeter

tests/src/Makefile.am

Lines changed: 37 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@ libsystem_la_LIBADD = -ldl $(GLIB_LIBS)
1515
libsystem_la_LDFLAGS = -rpath /nowhere
1616

1717
if COMPILE_LIBLIGHTDM_QT4
18-
noinst_PROGRAMS += test-qt-greeter
18+
noinst_PROGRAMS += test-qt4-greeter
19+
endif
20+
21+
if COMPILE_LIBLIGHTDM_QT5
22+
noinst_PROGRAMS += test-qt5-greeter
1923
endif
2024

2125
dbus_env_CFLAGS = \
@@ -96,25 +100,45 @@ test_script_hook_LDADD = \
96100
$(GLIB_LIBS) \
97101
$(GIO_UNIX_LIBS)
98102

99-
test-qt-greeter_moc.cpp: test-qt-greeter.h
100-
$(MOC) $< -o $@
101-
test_qt_greeter_SOURCES = test-qt-greeter.cpp test-qt-greeter.h status.c status.h
102-
nodist_test_qt_greeter_SOURCES = test-qt-greeter_moc.cpp
103-
test_qt_greeter_CFLAGS = \
103+
test-qt4-greeter_moc4.cpp: test-qt-greeter.h
104+
$(MOC4) $< -o $@
105+
test-qt5-greeter_moc5.cpp: test-qt-greeter.h
106+
$(MOC5) $< -o $@
107+
common_qt_sources = test-qt-greeter.cpp test-qt-greeter.h status.c status.h
108+
test_qt4_greeter_SOURCES = $(common_qt_sources)
109+
test_qt5_greeter_SOURCES = $(common_qt_sources)
110+
nodist_test_qt4_greeter_SOURCES = test-qt4-greeter_moc4.cpp
111+
nodist_test_qt5_greeter_SOURCES = test-qt5-greeter_moc5.cpp
112+
common_qt_cflags = \
104113
$(GLIB_CFLAGS) \
105114
$(GIO_UNIX_CFLAGS) \
106115
$(XCB_CFLAGS)
107-
test_qt_greeter_CXXFLAGS = \
116+
test_qt4_greeter_CFLAGS = $(common_qt_cflags)
117+
test_qt5_greeter_CFLAGS = $(common_qt_cflags)
118+
common_qt_cxxflags = \
119+
-fPIC \
120+
-DQT_DISABLE_DEPRECATED_BEFORE="QT_VERSION_CHECK(4, 0, 0)" \
108121
-I$(top_srcdir)/liblightdm-qt \
109-
$(LIBLIGHTDM_QT4_CFLAGS) \
110122
$(GLIB_CFLAGS)
111-
test_qt_greeter_LDADD = \
123+
test_qt4_greeter_CXXFLAGS = \
124+
$(common_qt_cxxflags) \
125+
$(LIBLIGHTDM_QT4_CFLAGS)
126+
test_qt5_greeter_CXXFLAGS = \
127+
$(common_qt_cxxflags) \
128+
$(LIBLIGHTDM_QT5_CFLAGS)
129+
common_qt_ldadd = \
112130
-L$(top_builddir)/liblightdm-qt \
113-
-llightdm-qt-2 \
114-
$(LIBLIGHTDM_QT4_LIBS) \
115131
$(GLIB_LIBS) \
116132
$(GIO_UNIX_LIBS) \
117133
$(XCB_LIBS)
134+
test_qt4_greeter_LDADD = \
135+
$(common_qt_ldadd) \
136+
-llightdm-qt-2 \
137+
$(LIBLIGHTDM_QT4_LIBS)
138+
test_qt5_greeter_LDADD = \
139+
$(common_qt_ldadd) \
140+
-llightdm-qt5-2 \
141+
$(LIBLIGHTDM_QT5_LIBS)
118142

119143
test_session_SOURCES = test-session.c status.c status.h
120144
test_session_CFLAGS = \
@@ -157,4 +181,5 @@ vnc_client_LDADD = \
157181
$(GIO_UNIX_LIBS)
158182

159183
CLEANFILES = \
160-
test-qt-greeter_moc.cpp
184+
test-qt4-greeter_moc4.cpp \
185+
test-qt5-greeter_moc5.cpp

tests/test-autologin-qt-timeout

Lines changed: 0 additions & 2 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#!/bin/sh
2-
./src/dbus-env ./src/test-runner autologin-guest-timeout test-qt-greeter
2+
./src/dbus-env ./src/test-runner autologin-guest-timeout test-qt4-greeter

tests/test-autologin-qt4-timeout

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner autologin-timeout test-qt4-greeter
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner autologin-guest-timeout test-qt5-greeter

tests/test-autologin-qt5-timeout

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner autologin-timeout test-qt5-greeter

tests/test-login-qt

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-guest

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-guest-disabled

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-guest-logout

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-info-prompt

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-invalid-session

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-invalid-user

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-logout

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-long-password

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-long-username

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-manual

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-new-authtok

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-no-password

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-pick-session

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-previous-session

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-remote-session

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-two-factor

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt-wrong-password

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/test-login-qt4

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login test-qt4-greeter

tests/test-login-qt4-guest

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest test-qt4-greeter

tests/test-login-qt4-guest-disabled

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest-disabled test-qt4-greeter
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#!/bin/sh
2-
./src/dbus-env ./src/test-runner login-guest-fail-setup-script test-qt-greeter
2+
./src/dbus-env ./src/test-runner login-guest-fail-setup-script test-qt4-greeter

tests/test-login-qt4-guest-logout

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest-logout test-qt4-greeter
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#!/bin/sh
2-
./src/dbus-env ./src/test-runner login-guest-no-setup-script test-qt-greeter
2+
./src/dbus-env ./src/test-runner login-guest-no-setup-script test-qt4-greeter

tests/test-login-qt4-info-prompt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-info-prompt test-qt4-greeter

tests/test-login-qt4-invalid-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-invalid-session test-qt4-greeter

tests/test-login-qt4-invalid-user

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-invalid-user test-qt4-greeter

tests/test-login-qt4-logout

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-logout test-qt4-greeter

tests/test-login-qt4-long-password

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-long-password test-qt4-greeter

tests/test-login-qt4-long-username

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-long-username test-qt4-greeter

tests/test-login-qt4-manual

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-manual test-qt4-greeter
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#!/bin/sh
2-
./src/dbus-env ./src/test-runner login-manual-previous-session test-qt-greeter
2+
./src/dbus-env ./src/test-runner login-manual-previous-session test-qt4-greeter
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#!/bin/sh
2-
./src/dbus-env ./src/test-runner login-multi-info-prompt test-qt-greeter
2+
./src/dbus-env ./src/test-runner login-multi-info-prompt test-qt4-greeter

tests/test-login-qt4-new-authtok

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-new-authtok test-qt4-greeter

tests/test-login-qt4-no-password

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-no-password test-qt4-greeter

tests/test-login-qt4-pick-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-pick-session test-qt4-greeter

tests/test-login-qt4-previous-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-previous-session test-qt4-greeter

tests/test-login-qt4-remote-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-remote-session test-qt4-greeter

tests/test-login-qt4-two-factor

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-two-factor test-qt4-greeter

tests/test-login-qt4-wrong-password

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-wrong-password test-qt4-greeter

tests/test-login-qt5

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login test-qt5-greeter

tests/test-login-qt5-guest

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest test-qt5-greeter

tests/test-login-qt5-guest-disabled

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest-disabled test-qt5-greeter
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest-fail-setup-script test-qt5-greeter

tests/test-login-qt5-guest-logout

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest-logout test-qt5-greeter
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-guest-no-setup-script test-qt5-greeter

tests/test-login-qt5-info-prompt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-info-prompt test-qt5-greeter

tests/test-login-qt5-invalid-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-invalid-session test-qt5-greeter

tests/test-login-qt5-invalid-user

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-invalid-user test-qt5-greeter

tests/test-login-qt5-logout

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-logout test-qt5-greeter

tests/test-login-qt5-long-password

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-long-password test-qt5-greeter

tests/test-login-qt5-long-username

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-long-username test-qt5-greeter

tests/test-login-qt5-manual

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-manual test-qt5-greeter
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-manual-previous-session test-qt5-greeter
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-multi-info-prompt test-qt5-greeter

tests/test-login-qt5-new-authtok

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-new-authtok test-qt5-greeter

tests/test-login-qt5-no-password

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-no-password test-qt5-greeter

tests/test-login-qt5-pick-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-pick-session test-qt5-greeter

tests/test-login-qt5-previous-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-previous-session test-qt5-greeter

tests/test-login-qt5-remote-session

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-remote-session test-qt5-greeter

tests/test-login-qt5-two-factor

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-two-factor test-qt5-greeter

tests/test-login-qt5-wrong-password

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
./src/dbus-env ./src/test-runner login-wrong-password test-qt5-greeter

0 commit comments

Comments
 (0)