Test LightDM handles a greeter crash

Author: robert-ancell

tests/Makefile.am

@@ -5,6 +5,7 @@ TESTS = \
 	test-greeter-fail-start \
 	test-greeter-not-installed \
 	test-greeter-xserver-crash \
+	test-greeter-crash \
 	test-greeter-wrapper \
 	test-greeter-default-session \
 	test-greeter-allow-guest \
@@ -342,6 +343,7 @@ EXTRA_DIST = \
 	scripts/denied.conf \
 	scripts/expired.conf \
 	scripts/greeter-allow-guest.conf \
+	scripts/greeter-crash.conf \
 	scripts/greeter-default-session.conf \
 	scripts/greeter-fail-start.conf \
 	scripts/greeter-hide-users.conf \

tests/scripts/greeter-crash.conf

@@ -0,0 +1,30 @@
+#
+# Check crashing greeter stops daemon
+#
+
+#?*START-DAEMON
+#?RUNNER DAEMON-START
+
+# X server starts
+#?XSERVER-0 START VT=7 SEAT=seat0
+
+# Daemon connects when X server is ready
+#?*XSERVER-0 INDICATE-READY
+#?XSERVER-0 INDICATE-READY
+#?XSERVER-0 ACCEPT-CONNECT
+
+# Greeter starts
+#?GREETER-X-0 START XDG_SEAT=seat0 XDG_VTNR=7 XDG_SESSION_CLASS=greeter
+#?XSERVER-0 ACCEPT-CONNECT
+#?GREETER-X-0 CONNECT-XSERVER
+#?GREETER-X-0 CONNECT-TO-DAEMON
+#?GREETER-X-0 CONNECTED-TO-DAEMON
+
+# Crash greeter
+#?*GREETER-X-0 CRASH
+
+# X server stopped
+#?XSERVER-0 TERMINATE SIGNAL=15
+
+# Daemon stops with error
+#?RUNNER DAEMON-EXIT STATUS=1

tests/src/test-gobject-greeter.c

@@ -79,7 +79,10 @@ request_cb (const gchar *name, GHashTable *params)
         return;
     }
 
-    if (strcmp (name, "AUTHENTICATE") == 0)
+    if (strcmp (name, "CRASH") == 0)
+        kill (getpid (), SIGSEGV);
+
+    else if (strcmp (name, "AUTHENTICATE") == 0)
         lightdm_greeter_authenticate (greeter, g_hash_table_lookup (params, "USERNAME"));
 
     else if (strcmp (name, "AUTHENTICATE-GUEST") == 0)

tests/test-greeter-crash

@@ -0,0 +1,2 @@
+#!/bin/sh
+./src/dbus-env ./src/test-runner greeter-crash test-gobject-greeter