Fix virtual camera action selection causing a crash

WarmUpTill · WarmUpTill · commit 132d89b35061 · 2024-03-06T12:53:43.000+01:00
The Create() and Copy() functions were not correctly implemented and
returned a nullptr
diff --git a/plugins/base/macro-action-virtual-cam.cpp b/plugins/base/macro-action-virtual-cam.cpp
@@ -67,12 +67,12 @@ bool MacroActionVCam::Load(obs_data_t *obj)
 
 std::shared_ptr<MacroAction> MacroActionVCam::Create(Macro *m)
 {
-	return std::shared_ptr<MacroAction>();
+	return std::make_shared<MacroActionVCam>(m);
 }
 
 std::shared_ptr<MacroAction> MacroActionVCam::Copy() const
 {
-	return std::shared_ptr<MacroAction>();
+	return std::make_shared<MacroActionVCam>(*this);
 }
 
 static inline void populateActionSelection(QComboBox *list)

Original file line number	Diff line number	Diff line change
`@@ -67,12 +67,12 @@ bool MacroActionVCam::Load(obs_data_t *obj)`
`67`	`67`
`68`	`68`	`std::shared_ptr<MacroAction> MacroActionVCam::Create(Macro *m)`
`69`	`69`	`{`
`70`		`- return std::shared_ptr<MacroAction>();`
	`70`	`+ return std::make_shared<MacroActionVCam>(m);`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`std::shared_ptr<MacroAction> MacroActionVCam::Copy() const`
`74`	`74`	`{`
`75`		`- return std::shared_ptr<MacroAction>();`
	`75`	`+ return std::make_shared<MacroActionVCam>(*this);`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`static inline void populateActionSelection(QComboBox *list)`