Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algorithm class iteration loop is unclear #2063

Open
MargaretDuff opened this issue Feb 6, 2025 · 0 comments · May be fixed by #2069
Open

Algorithm class iteration loop is unclear #2063

MargaretDuff opened this issue Feb 6, 2025 · 0 comments · May be fixed by #2069
Assignees
@MargaretDuff

Comments

@MargaretDuff
Copy link
Member

Description

In the algorithm class code, the call to next and update is hidden in this line:

CIL/Wrappers/Python/cil/optimisation/algorithms/Algorithm.py

Line 279 in 5749b38

for _ in zip(iters, self):

This is unclear to users (and developers) and makes debugging hard. We should at least add a comment!
@MargaretDuff MargaretDuff added bug Something isn't working and removed bug Something isn't working labels Feb 6, 2025
@MargaretDuff MargaretDuff linked a pull request Feb 10, 2025 that will close this issue
Open
9 tasks
@MargaretDuff MargaretDuff linked a pull request Feb 10, 2025 that will close this issue
Make the call to next() in algorithm iteration loop explicit #2069
Open
9 tasks
@MargaretDuff MargaretDuff self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MargaretDuff MargaretDuff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the call to next() in algorithm iteration loop explicit TomographicImaging/CIL
1 participant
@MargaretDuff