Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with PDHG result not matching FISTA in 01_optimisation #196

Open
lauramurgatroyd opened this issue Oct 22, 2024 · 3 comments
Open
Assignees

Comments

@lauramurgatroyd
Copy link
Member

The notebook claims that the result of PDHG will look the same as the result of FISTA

However, this is what I get with PDHG:

Image

This was the FISTA result:
Image

Also with PDHG I get a warning:
miniconda3/envs/cil_24.2/Lib/site-packages/cil/optimisation/algorithms/PDHG.py:393: UserWarning: Convergence criterion of PDHG for scalar step-sizes is not satisfied.
warnings.warn("Convergence criterion of PDHG for scalar step-sizes is not satisfied.")

@MargaretDuff
Copy link
Member

To get rid of the error - add "check_convergence = False" to the PDHG set up. I will add an issue in CIL to remove this but this will be a future version and we want to run the notebooks on 24.2.0

@MargaretDuff
Copy link
Member

MargaretDuff commented Oct 22, 2024

The notebook first runs 500 iterations of PDHG
Image
and then further runs up to 5000 iterations of PDHG for the primal dual gap to shrink:
Image

I suggest we change the statement that the FISTA and PDHG results will look the same to be in reference to the 5000 iteration image

@lauramurgatroyd lauramurgatroyd self-assigned this Oct 22, 2024
@lauramurgatroyd
Copy link
Member Author

Currently can't add convergence check due to TomographicImaging/CIL#1965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants