Skip to content

Commit 990de35

Browse files
committed
pass more
1 parent 55e399c commit 990de35

File tree

7 files changed

+22
-7
lines changed

7 files changed

+22
-7
lines changed

sonar-plugin/bridge/pom.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
<dependency>
7676
<groupId>org.java-websocket</groupId>
7777
<artifactId>Java-WebSocket</artifactId>
78-
<version>1.5.4</version>
78+
<version>1.5.7</version>
7979
</dependency>
8080
</dependencies>
8181
<build>
@@ -209,4 +209,11 @@
209209
</plugin>
210210
</plugins>
211211
</build>
212+
<repositories>
213+
<repository>
214+
<id>maven_central</id>
215+
<name>Maven Central</name>
216+
<url>https://repo.maven.apache.org/maven2/</url>
217+
</repository>
218+
</repositories>
212219
</project>

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/Http.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class JdkHttp implements Http {
4343
private final HttpClient client;
4444

4545
JdkHttp() {
46-
this.client = HttpClient.newBuilder().build();
46+
this.client = HttpClient.newBuilder().version(HttpClient.Version.HTTP_1_1).build();
4747
}
4848

4949
@Override

sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/JavaScriptPlugin.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import org.sonar.plugins.javascript.bridge.BundleImpl;
4343
import org.sonar.plugins.javascript.bridge.EmbeddedNode;
4444
import org.sonar.plugins.javascript.bridge.Environment;
45+
import org.sonar.plugins.javascript.bridge.JSWebSocketClient;
4546
import org.sonar.plugins.javascript.bridge.NodeDeprecationWarning;
4647
import org.sonar.plugins.javascript.bridge.RulesBundles;
4748
import org.sonar.plugins.javascript.external.TslintReportSensor;
@@ -165,7 +166,8 @@ public void define(Context context) {
165166
YamlSensor.class,
166167
HtmlSensor.class,
167168
EmbeddedNode.class,
168-
Environment.class
169+
Environment.class,
170+
JSWebSocketClient.class
169171
);
170172

171173
context.addExtensions(

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/JavaScriptPluginTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
class JavaScriptPluginTest {
3838

39-
private static final int BASE_EXTENSIONS = 35;
39+
private static final int BASE_EXTENSIONS = 36;
4040
private static final int SCANNER_EXTENSIONS = 10;
4141
private static final int SONARLINT_ADDITIONAL_EXTENSIONS = 3;
4242

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/analysis/CssRuleSensorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ void test_no_file_to_analyze() {
252252
}
253253

254254
@Test
255-
void failed_server_should_log_error_with_css() throws IOException {
255+
void failed_server_should_log_error_with_css() throws IOException, InterruptedException {
256256
doThrow(new NodeCommandException("Exception Message"))
257257
.when(bridgeServerMock)
258258
.startServerLazily(any());

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/analysis/JavaScriptEslintBasedSensorTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
import static org.mockito.Mockito.times;
2828
import static org.mockito.Mockito.verify;
2929
import static org.mockito.Mockito.when;
30-
import static org.sonar.plugins.javascript.analysis.JsTsSensorTest.PLUGIN_VERSION;
30+
31+
//import static org.sonar.plugins.javascript.analysis.JsTsSensorTest.PLUGIN_VERSION;
3132

3233
import com.google.gson.Gson;
3334
import java.io.File;
@@ -135,7 +136,7 @@ void setUp() throws Exception {
135136
// reset is required as this static value might be set by another test
136137
PluginInfo.setUcfgPluginVersion(null);
137138
// this is required to avoid the test to use real plugin version from the manifest
138-
PluginInfo.setVersion(PLUGIN_VERSION);
139+
// PluginInfo.setVersion(PLUGIN_VERSION);
139140

140141
// Avoid shortpaths on windows
141142
baseDir = baseDir.toRealPath();

sonar-plugin/standalone/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
<groupId>${project.groupId}</groupId>
1818
<artifactId>bridge</artifactId>
1919
</dependency>
20+
<dependency>
21+
<groupId>org.java-websocket</groupId>
22+
<artifactId>Java-WebSocket</artifactId>
23+
<version>1.5.7</version>
24+
</dependency>
2025
<dependency>
2126
<groupId>org.sonarsource.api.plugin</groupId>
2227
<artifactId>sonar-plugin-api</artifactId>

0 commit comments

Comments
 (0)