Merge pull request #395 from SciML/bump_groebner09

Bump Groebner 0.9 and use new functionality

Author: pogudingleb

Project.toml

@@ -35,21 +35,21 @@ CPUSummary = "0.2"
 Combinatorics = "1"
 DataStructures = "0.18"
 Dates = "1.10, 1.11"
-Groebner = "0.8.1"
+Groebner = "0.9"
 IterTools = "1"
 LinearAlgebra = "1.10, 1.11"
 Logging = "1.10, 1.11"
 MacroTools = "0.5"
 ModelingToolkit = "9.33"
-Nemo = "0.46, 0.47, 0.48"
+Nemo = "0.46, 0.47, 0.48, 0.49"
 ParamPunPam = "0.5"
 Pkg = "1.10, 1.11"
 PrecompileTools = "1.2"
 Primes = "0.5"
 Random = "1.10, 1.11"
 SpecialFunctions = "2"
-SymbolicUtils = "3.7"
-Symbolics = "6.16"
+SymbolicUtils = "3.14"
+Symbolics = "6.29"
 Test = "1.10, 1.11"
 TestSetExtensions = "2"
 TimerOutputs = "0.5"

src/RationalFunctionFields/normalforms.jl

@@ -12,14 +12,14 @@ end
 
 function Base.push!(tref::TinyRowEchelonForm{T}, vect::Vector{T}) where {T}
     @assert count(!iszero, vect) == 1
-    @assert !in(tref, vect)
+    @assert !in(vect, tref)
     pivot = findfirst(!iszero, vect)
     push!(tref.rows, vect)
     push!(tref.pivot_cols, pivot)
     return vect
 end
 
-function Base.in(tref::TinyRowEchelonForm{T}, vect::Vector{T}) where {T}
+function Base.in(vect::Vector{T}, tref::TinyRowEchelonForm{T}) where {T}
     nnz_inds = findall(!iszero, vect)
     for i in nnz_inds
         rref_idx = findfirst(pivot_col -> pivot_col == i, tref.pivot_cols)
@@ -72,7 +72,7 @@ function local_normal_forms(
     for deg in 1:up_to_degree
         for combination in Combinatorics.with_replacement_combinations(pivot_vectors, deg)
             exp_vect = sum(combination)
-            if in(stop_vectors, exp_vect)
+            if in(exp_vect, stop_vectors)
                 @debug "Skipping exponent vector $exp_vect"
                 continue
             end

src/primality_check.jl

@@ -1,47 +1,8 @@
-# ------------------------------------------------------------------------------
-# adapted from https://gitlab.inria.fr/newrur/code/-/blob/main/Julia/RationalUnivariateRepresentation.jl/src/RationalUnivariateRepresentation.jl?ref_type=heads#L180
-# thanks to Alexander Demin
-"""
-    quotient_basis(J::Array{QQMPolyRingElem, 1})
-
-Takes as input a Groebner basis J of a zero-dimensional ideal and
-returns a monomial basis of the quotient ring
-(more precisely, the list of standard monomials)
-"""
-function quotient_basis(J::Array{<:MPolyRingElem, 1})
-    if !Groebner.isgroebner(J)
-        throw(DomainError("Input is not a Groebner basis"))
-    end
-    n = length(gens(parent(first(J))))
-    leading_exponents = [first(Nemo.exponent_vectors(Nemo.leading_monomial(p))) for p in J]
-    if length(filter(e -> count(iszero, e) == n - 1, leading_exponents)) < n
-        throw(DomainError("Input does not define zerodimensional ideal"))
-    end
-    exponents_to_check = [[0 for _ in 1:n]]
-    exponents_checked = []
-    basis_exponents = []
-    while length(exponents_to_check) > 0
-        e = popfirst!(exponents_to_check)
-        push!(exponents_checked, e)
-        if !any(map(le -> all(e .>= le), leading_exponents))
-            push!(basis_exponents, e)
-            for i in 1:n
-                next_e = copy(e)
-                next_e[i] += 1
-                if !(next_e in exponents_checked) && !(next_e in exponents_to_check)
-                    push!(exponents_to_check, next_e)
-                end
-            end
-        end
-    end
-    return [prod(gens(parent(first(J))) .^ e) for e in basis_exponents]
-end
-
 # ------------------------------------------------------------------------------
 
 function check_primality_zerodim(J::Array{QQMPolyRingElem, 1})
     J = Groebner.groebner(J)
-    basis = quotient_basis(J)
+    basis = Groebner.quotient_basis(J)
     dim = length(basis)
     S = Nemo.matrix_space(Nemo.QQ, dim, dim)
     matrices = []