Skip to content

section 6.3.1, computational constraint is not implemented #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaeyoon-enerzai opened this issue Apr 27, 2025 · 0 comments
Open

section 6.3.1, computational constraint is not implemented #253

jaeyoon-enerzai opened this issue Apr 27, 2025 · 0 comments
Labels
question Further information is requested

Comments

@jaeyoon-enerzai
Copy link

Prerequisites

Before submitting your question, please ensure the following:

  • [ O ] I am running the latest version of PowerInfer. Development is rapid, and as of now, there are no tagged versions.
  • [ O ] I have carefully read and followed the instructions in the README.md.
  • [ O ] I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).

Question Details

I reviewed the entire repository and noticed that the threshold parameter is not actually used.
In powerinfer-py/powerinfer/main.py, there is an argument named threshold, which seems to correspond to C_l in Equation 7 of the paper.
However, in llama.cpp, at line 3126, the PowerInfer Python module is called without passing the threshold argument.
Additionally, I could not find any implementation of the computation constraint described in Equations 4 and 5 of Section 6.3.1.

Was it intentional to omit the computation constraint?

Additional Context

Please provide any additional information that may be relevant to your question, such as specific system configurations, environment details, or any other context that could be helpful in addressing your inquiry.

Thanks, in advance

@jaeyoon-enerzai jaeyoon-enerzai added the question Further information is requested label Apr 27, 2025
@jaeyoon-enerzai jaeyoon-enerzai changed the title section 6.3.1 is not implemented section 6.3.1, computational constraint is not implemented Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant