Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] rsx: Finish MSAA implementation #16584

Open
kd-11 opened this issue Jan 19, 2025 · 3 comments
Open

[Task] rsx: Finish MSAA implementation #16584

kd-11 opened this issue Jan 19, 2025 · 3 comments
Assignees

Comments

@kd-11
Copy link
Contributor

kd-11 commented Jan 19, 2025

MSAA work is completed for vulkan but is missing for OpenGL. It also doesn't work with the interpreter.
We already have most of the kinks worked out by now, so this is long overdue.

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Jan 19, 2025

This issue ties into #12166

@digant73
Copy link
Contributor

This issue ties into #12166

That is for OpenGL where the Anti-Aliasing setting is not enabled at all. While MSAA is not working on Vulkan with Interpreter only shader

@kd-11
Copy link
Contributor Author

kd-11 commented Jan 19, 2025

Both need to be fixed since OpenGL also supports the interpreter.
In the past when MSAA was added, I decided to only add to one backend while we figured out the best way to integrate the feature. OGL has a stubbed implementation because of that. The interpreters use shared code and it doesn't support MSAA at the moment. Makes sense to just do both (start with OGL then fix interpreter so it works on all backends)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants