Update s3user error messages for policy application

Author: sdodsley

changelogs/fragments/353_s3user_enhanced_policy_reporting.yaml

@@ -0,0 +1,3 @@
+minor_changes:
+ - purefb_s3user - Updated failure messages for applying policies to an object user account.
+ - purefb_s3user - Changed ``key_state`` state to be ``keystate`` as ``key_state`` is reserved.

plugins/modules/purefb_s3user.py

@@ -29,7 +29,7 @@
     - Create or delete object store account user
     - Remove a specified access key for a user
     default: present
-    choices: [ absent, present, remove_key, key_state ]
+    choices: [ absent, present, remove_key, keystate ]
     type: str
   name:
     description:
@@ -107,7 +107,7 @@
     account: bar
     access_key: true
     policy:
-      - pure:policy/safemode-configure
+      - pure:policy/object-write
     fb_url: 10.10.10.2
     api_token: T-55a68eb5-c785-4720-a2ca-8b03903bf641
 
@@ -364,8 +364,10 @@ def create_s3user(module, blade):
                     )
                     if res.status_code != 200:
                         module.warn(
-                            "Failed to add policy {0} to account user {1}. Skipping...".format(
-                                policy_list[policy], username
+                            "Failed to add policy {0} to account user {1}. Error: {2}. Skipping...".format(
+                                policy_list[policy],
+                                username,
+                                res.errors[0].message,
                             )
                         )
             if "pure:policy/full-access" not in policy_list:
@@ -456,7 +458,7 @@ def main():
             policy=dict(type="list", elements="str"),
             state=dict(
                 default="present",
-                choices=["present", "absent", "remove_key", "key_state"],
+                choices=["present", "absent", "remove_key", "keystate"],
             ),
         )
     )
@@ -504,7 +506,7 @@ def main():
         create_s3user(module, blade)
     elif state == "remove_key" and s3user:
         remove_key(module, blade)
-    elif state == "key_state" and s3user:
+    elif state == "keystate" and s3user:
         change_key(module, blade)
     else:
         module.exit_json(changed=False)