Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move handlebars templates #21

Open
Miljar opened this issue Feb 19, 2015 · 2 comments
Open

Move handlebars templates #21

Miljar opened this issue Feb 19, 2015 · 2 comments
Assignees
@jnstr
Milestone
Customization (v2)

Comments

@Miljar
Copy link
Member

Miljar commented Feb 19, 2015

Currently the handlebars templates are inside the main index.html file.
They should be moved to separate files in a theme folder.

Proposed layout:

themes/
------/php-wvl
--------------/templates
------------------------/whatever.js
--------------/css
--------------/assets
--------------/js
@Miljar Miljar added this to the Customization (v2) milestone Feb 19, 2015
@Miljar Miljar mentioned this issue Feb 19, 2015
Open
@jnstr jnstr self-assigned this Feb 19, 2015
@jnstr
Copy link
Contributor

jnstr commented Feb 19, 2015

I'll combine this with #11

@Miljar
Copy link
Member Author

Miljar commented Feb 19, 2015

The templates should also be loaded via RequireJS. Check slide 38 http://www.slideshare.net/iivanoo/requirejs-handlebars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnstr jnstr

Labels
None yet
Projects
None yet
Milestone
Customization (v2)
Development

No branches or pull requests
2 participants
@Miljar @jnstr