project_timeline: Module modification

[aps2201]

module: project_timeline
version: 17.0

In reference to this issue: #933

I see people here don't want to change it for some reason.

Consider that changing features in OCA modules must be done by keeping in mind the needs of users already emplyoing the module (eg: maybe the're a reason "Extra info" is only available in developer mode)

I found PR from a few months ago that claimed "Because setting them manually without the timeline view is not the usual way" #1335 (comment) but I can't understand that reasoning also. If we create the task from the timeline view you still need access to the extra_info tab so it doesn't seem to explain anything. Anyway I did an edit to addons/project/project_timeline/views/project_task_view.xml around line 109

<field name="inherit_id" ref="project.view_task_form2" />
        <field name="arch" type="xml">
            <xpath expr="//page[@name='task_dependencies']" position="after">
            	<page name="timeline_plan" string='Timeline'>
                <field
                    name="planned_date_start"
                    widget="daterange"
                    options="{'end_date_field': 'planned_date_end'}"
                    string="Planned Dates"
                />
                <field name="planned_date_end" invisible="1" />
                </page>
            </xpath>
        </field>

This creates a new tab "Timeline" in the form, but somehow I can't label them (which is fine since it serves my purpose) . I have yet to see any negative impacts for myself but is there really any? Is there a better solution for making the timeline not hidden?

PS: I'm sorry if this is spammy since I already left a comment on #933 (comment) but the issue seems to be closed.

[pedrobaeza]

I don't get what you want, but creating a tab just for 2 fields is overkill. The fields already exist in the form. If you don't want it that way, just customize in your own DB.

[aps2201]

Hi, yes it is overkill but that is the only workaround I can think of do you have any better ideas? What I want is the same as what everyone else wants, a way to ability to the set the start/end times for the project without the developer mode. Its been asked before here #1335 (comment) and here #933 (comment) so I'm pretty sure you are familiar with the question.

[pedrobaeza]

You can do it using base_technical_features or debug mode as stated before.

[pedrobaeza]

Anyway, just forward-port #1377 to 17.0 and you'll have it without technical features enabled. Can you do the PR?

[aps2201]

I'd love to help but I have no prior experience with working a PR. Any pointers?

[pedrobaeza]

No matter. I have just done it: #1429

[aps2201]

Much thanks. This seems to fit my needs.