Skip to content

nodejs: unexpected behaviour / usage of hiprio #413155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
h0nIg opened this issue Jun 2, 2025 · 3 comments · May be fixed by #413169
Open
3 tasks done

nodejs: unexpected behaviour / usage of hiprio #413155

h0nIg opened this issue Jun 2, 2025 · 3 comments · May be fixed by #413169
Labels
0.kind: bug Something is broken

Comments

@h0nIg
Copy link
Contributor

h0nIg commented Jun 2, 2025

Nixpkgs version

  • Stable (25.05)

Describe the bug

hiPrio usage was introduced by 6462eb6 / @domenkozar - unfortunately without reasoning.

We suddenly ran into the situation, that nixpkgs.nodejs (nodejs v22) and nixpkgs.nodejs_20 were in the nested buildInputs, but the collision was not detected. We were wondering why nodejs will always win, until we have noticed the hiPrio usage. Users do not expect something to happen for all-packages.nix attributes, please reconsider the usage - it looks like a quick fix which is 8 years old.

Steps to reproduce

  pkgs.buildEnv rec {
    name = "xxx";
    paths = [pkgs.nodejs_20 pkgs.nodejs];
  }

Expected behaviour

collision error

Screenshots

No response

Relevant log output

Additional context

No response

System metadata

n/a

Notify maintainers


Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

Is this issue important to you?

Add a 👍 reaction to issues you find important.

@h0nIg h0nIg added the 0.kind: bug Something is broken label Jun 2, 2025
@h0nIg
Copy link
Contributor Author

h0nIg commented Jun 2, 2025

CC @aduh95

@aduh95
Copy link
Contributor

aduh95 commented Jun 2, 2025

I don't have more context that what you shared on why we're using hiPrio; as you linked, it's been this way since long before I was involved with Nix or even Node.js. I don't have any objection for changing that as long as we don't backport the change.

@h0nIg h0nIg linked a pull request Jun 2, 2025 that will close this issue
13 tasks
@h0nIg
Copy link
Contributor Author

h0nIg commented Jun 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants