Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniProfiler.Settings.MaxJsonResponseSize doesn't exist anymore -- replacement or un-needed? #677

Open
jrmoreno1 opened this issue Oct 31, 2024 · 2 comments

Comments

@jrmoreno1
Copy link

MiniProfiler.Settings.cs was removed with commit 8e36f48, and with it MaxJsonResponseSize. I don't see a replacement. Am I missing something, and there is a new property somewhere else, or is it not needed any more?

@NickCraver
Copy link
Member

What option is this referring to? Though it's been a hot minute, I don't recall a MaxJsonResponseSize and it didn't exist as of the linked commit: https://github.com/MiniProfiler/dotnet/blob/8ec74c1aa4c631c40bc25f0d7c18a9efb84cddc5/src/MiniProfiler.Shared/MiniProfiler.Settings.cs

@jrmoreno1
Copy link
Author

jrmoreno1 commented Dec 19, 2024

I think it was last included with commit 1f8c54a

Code was (in StackExchange.Profiling/MiniProfiler.Settings.cs):

  /// <summary>
  /// Maximum payload size for json responses in bytes defaults to 2097152 characters, which is equivalent to 4 MB of Unicode string data.
  /// </summary>
  [DefaultValue(2097152)]
  public static int MaxJsonResponseSize { get; set; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants