Skip to content

Pin selenium-webdriver to a specific version (OSOE-1070) #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
Piedone opened this issue Mar 19, 2025 · 0 comments · Fixed by #534
Closed
2 tasks done

Pin selenium-webdriver to a specific version (OSOE-1070) #482

Piedone opened this issue Mar 19, 2025 · 0 comments · Fixed by #534
Assignees

Comments

@Piedone
Copy link
Member

Piedone commented Mar 19, 2025

SetupNodeDependenciesAsync dynamically creates a packages.json file, installing the latest version of selenium-webdriver. This can introduce breaking changes at any time, suddenly breaking our tests.

Instead, change this so the selenium-webdriver version is pinned and only updated consciously.

  • The selenium-webdriver version is pinned. Ideally, this wouldn't work with anything special, and we'd use just a standard, static packages.json file. However, we don't need to install anything with that (like with NPM Targets), so maybe just having a const for the version string and updating how the ZAP version is updated (see renovate.json5) is the way to go.
  • The selenium-webdriver version is updated by Renovate automatically. If we use a packages.json file, then nothing else to do. This can be enough by using ConstantFromJson from Helpful Libraries instead of a hard-coded version. Otherwise, Renovate will need to have a regex customManager configured to update the version number. For examples, see the renovate.json5 file in the root.

Jira issue

@github-actions github-actions bot changed the title Pin selenium-webdriver to a specific version Pin selenium-webdriver to a specific version (OSOE-1070) Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant