Does camp require umpire?

[chapman39]

Axom requires umpire in order to properly set CAMP_DIR.

axom/scripts/spack/packages/axom/package.py

Line 536 in c98d4ac

entries.append(cmake_cache_path("CAMP_DIR", dep_dir))

But, is this necessary? Does this mean you can't have Camp without Umpire? If not, I suggest this:

        if spec.satisfies("^camp"):
            dep_dir = get_spec_path(spec, "camp", path_replacements)
            entries.append(cmake_cache_path("CAMP_DIR", dep_dir))

If Camp does require umpire, then this means Serac always depends on umpire (given Serac always depends on axom and camp) and should no longer have an umpire variant.

[chapman39]

I ran into this because my Serac build was auto-disabling just umpire (i.e. I had +raja~umpire), which is fun...

This caused the axom build to fail, since it wasn't setting CAMP_DIR.

[kennyweiss]

I don't think Axom directly uses camp, only as a dependency from raja or umpire.

I see that we have this logic in Axom's spack package:

axom/scripts/spack/packages/axom/package.py

Lines 534 to 536 in c98d4ac

	if spec.satisfies("+umpire") and spec.satisfies("^camp"):
	dep_dir = get_spec_path(spec, "camp", path_replacements)
	entries.append(cmake_cache_path("CAMP_DIR", dep_dir))

I wonder if it should be

        if (spec.satisfies("+umpire") or spec.satisfies("+raja")) and spec.satisfies("^camp"):

Tag: @white238

[chapman39]

That does match this: https://github.com/LLNL/axom/blob/develop/src/cmake/thirdparty/SetupAxomThirdParty.cmake#L33

so it might work.

[kennyweiss]

If Camp does require umpire, then this means Serac always depends on umpire (given Serac always depends on axom and camp) and should no longer have an umpire variant.

It's the other way around -- camp is a required dependency for umpire (and also for raja).
But, both raja and umpire are optional dependencies for axom.
So if serac depends on axom and camp, it sounds like you might need to add a depends_on("camp") to serac's spack package.

This looks right to me:

graph TD
  raja --> camp
  umpire --> camp
  axom -.-> umpire
  axom -.-> raja
  serac --> axom
  serac -.-> umpire
  serac -.-> raja
  serac --> camp

Loading

(I'm basing the serac dependencies on your description).