Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible feature: use system cmake if found and meets required minimum version #4

Open
tkelman opened this issue Mar 6, 2017 · 3 comments

Comments

@tkelman
Copy link

tkelman commented Mar 6, 2017

Could have some way of packages specifying what cmake version they need, and if this package finds a good enough cmake on the path it would use it instead of needing to download a private copy every time? It's not a huge download, but it does seem a bit wasteful if there's already a copy installed, especially on architectures where this package would otherwise need to build cmake from source.

@rdeits
Copy link
Collaborator

rdeits commented Mar 6, 2017

Yeah, I would like to do that eventually. I chose the current design because I'm building a couple of projects that require ridiculously modern cmake versions (like 3.5-3.7), so system cmake is almost never good enough. But yes, it would be nice to defer to the system cmake if it's good enough for a particular build.

@tkelman
Copy link
Author

tkelman commented Mar 6, 2017

Has cmake really been adding features recently that people are already wanting to use? I thought LLVM was pretty arbitrary in picking 3.4.3 and that's the newest requirement I've encountered.

@rdeits
Copy link
Collaborator

rdeits commented Mar 6, 2017

The one I deal with most often is our lab's code in https://github.com/RobotLocomotion/drake which requires cmake 3.5 and uses features back-ported from 3.7 via some extra modules. Some of its dependencies have also been upgraded to require at least 3.5. I don't know what features are actually being used, though (we have some external developers who are handling the build systems).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants