Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update processor_x86 with Zen4 and newer Intel #50178

Closed
vchuravy opened this issue Jun 15, 2023 · 3 comments · Fixed by #52944
Closed

Update processor_x86 with Zen4 and newer Intel #50178

vchuravy opened this issue Jun 15, 2023 · 3 comments · Fixed by #52944
Labels
compiler:llvm For issues that relate to LLVM good first issue Indicates a good issue for first-time contributors to Julia system:x86

Comments

@vchuravy
Copy link
Member

vchuravy commented Jun 15, 2023 •
edited
Loading

There are a bunch of new Intel chips and Zen4.

Zen4 was added in LLVM 16, but no reason to not detect it and fallback to Zen3 for the time being.

If anyone wants to try this. The relevant file is https://github.com/JuliaLang/julia/blob/0a05a5b05d382bdf38da7fdd0c069dff8bdc072c/src/processor_x86.cpp and I use https://github.com/llvm/llvm-project/blob/b163efae3312abe1227cff1d7704325138b4e538/llvm/lib/Target/X86/X86.td#L1749 as reference.

x-ref: JuliaCI/julia-buildkite#298
@vchuravy vchuravy added good first issue Indicates a good issue for first-time contributors to Julia compiler:llvm For issues that relate to LLVM system:x86 labels Jun 15, 2023
@gbaraldi
Copy link
Member

#44696 reference PR that added alder lake.

@hsradA23 hsradA23 mentioned this issue Jun 20, 2023
Closed
@varun-r-mallya
Copy link

Is this solved, can I work on it ?

@giordano giordano mentioned this issue Nov 6, 2024
Merged
@giordano
Copy link
Contributor

giordano commented Nov 6, 2024

Fixed by #52944.

@giordano giordano closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler:llvm For issues that relate to LLVM good first issue Indicates a good issue for first-time contributors to Julia system:x86
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add detection for zen 4 cpus in processor_x86 JuliaLang/julia
4 participants
@vchuravy @giordano @gbaraldi @varun-r-mallya