Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-table-partitions should take an option to specify target folder where yaml files are stored #1428

Open
sundar-mudupalli-work opened this issue Feb 7, 2025 · 0 comments

Comments

@sundar-mudupalli-work
Copy link
Collaborator

sundar-mudupalli-work commented Feb 7, 2025

Hi,

generate-table-partitions currently takes an option -cdir CONFIG_DIR to specify where the yaml files should be stored. What it does is to create another directory within this directory and then store the yaml files within that directory. The name of this other directory is <source_schema>.<source_table> if it is called with tables OR custom.<random5 char string> if it is called with a custom query. The second option is not user friendly.

We have two choices:

  1. Introduce a new parameter -fl or --folder-name to specify a name for the folder and if not provided default to current behavior. If we choose this approach, the change would need to be made here - in addition to adding a new parameter. OR
  2. Reinterpret CONFIG_DIR as the place to store yamls and store the yamls there.

Would love to hear from customers on the approach they prefer.

Sundar Mudupalli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant