Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract price always zero for public contracts with set price in ISK / Tracking. #468

Open
mourisson opened this issue Jun 8, 2024 · 1 comment
Labels
enhancement New Feature isk Isk Tool tracker Tracker Tool

Comments

@mourisson
Copy link

When having public contracts with a set price with abyss modules, they are not taken into account for ISK / Tracking tab.

If found through contract tool, they can be found with price there.

@GoldenGnu GoldenGnu added bug Defect tracker Tracker Tool isk Isk Tool labels Jul 9, 2024
@GoldenGnu GoldenGnu moved this to 🪲 Bugs in jEveAssets Development Sep 14, 2024
@GoldenGnu GoldenGnu added enhancement New Feature bug Defect and removed bug Defect enhancement New Feature labels Oct 15, 2024
@GoldenGnu
Copy link
Owner

I looked at the code

The contract is evaluated by the market price. Since abyssal modules are not on the market, they're evaluated at zero isk.
Contract reward and price are only used to compensate for out of sync account balance (but, it's also added to the contracts value)
So, this is not a bug, that is just how it works.

However, I think it would be a good idea to add the option to evaluate contracts by price/reward, so, I'm going to change this to a feature suggestion

@GoldenGnu GoldenGnu added enhancement New Feature and removed bug Defect labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Feature isk Isk Tool tracker Tracker Tool
Projects
None yet
Development

No branches or pull requests

2 participants