feat: add "lobby_player_yaw" config setting

Controls player facing when initially spawning in lobby, and also
teleporting back to lobby.

Author: desht

common/src/main/java/dev/ftb/mods/ftbteambases/config/ServerConfig.java

@@ -41,6 +41,8 @@ public interface ServerConfig {
             .comment("Position at which new players spawn. Only used if the lobby structure comes from a pregenerated region!");
     StringValue LOBBY_DIMENSION = LOBBY.addString("lobby_dimension", "minecraft:overworld")
             .comment("Dimension ID of the level in which the lobby is created. This *must* be a static pre-existing dimension, not a dynamically created one! New players will be automatically teleported to this dimension the first time they connect to the server. This setting should be defined in default config so the server has it before any levels are created - do NOT modify this on existing worlds!");
+    DoubleValue LOBBY_PLAYER_YAW = LOBBY.addDouble("lobby_player_yaw", 0.0, 0.0, 360.0)
+            .comment("Player Y-axis rotation when initially spawning in, or returning to, the lobby. (0 = south, 90 = west, 180 = north, 270 = east)");
 
     SNBTConfig WORLDGEN = CONFIG.addGroup("worldgen");
     EnumValue<ChunkGenerators> CHUNK_GENERATOR = WORLDGEN.addEnum("chunk_generator", ChunkGenerators.NAME_MAP)
@@ -62,7 +64,7 @@ public interface ServerConfig {
     BooleanValue ALLOW_NETHER_PORTALS = NETHER.addBoolean("allow_nether_portals", true)
             .comment("When set to true, nether portals may be constructed in team dimensions");
     BooleanValue TEAM_SPECIFIC_NETHER_ENTRY_POINT = NETHER.addBoolean("team_specific_nether_entry_point", true)
-            .comment("If true, then players going to the Nether via Nether Portal will be sent to a team-specific position in the Nether");
+            .comment("If true, then players going to the Nether via Nether Portal will be sent to a random (but deterministic for the team) position in the Nether");
 
     static Optional<ResourceLocation> lobbyLocation() {
         if (LOBBY_STRUCTURE_LOCATION.get().isEmpty()) {

common/src/main/java/dev/ftb/mods/ftbteambases/data/bases/BaseInstanceManager.java

@@ -264,7 +264,7 @@ public Optional<LiveBaseDetails> getBaseForTeam(Team team) {
 
     public boolean teleportToLobby(ServerPlayer serverPlayer) {
         ResourceKey<Level> destLevel = ServerConfig.lobbyDimension().orElse(Level.OVERWORLD);
-        return DimensionUtils.teleport(serverPlayer, destLevel, lobbySpawnPos);
+        return DimensionUtils.teleport(serverPlayer, destLevel, lobbySpawnPos, ServerConfig.LOBBY_PLAYER_YAW.get().floatValue());
     }
 
     public void deleteAndArchive(MinecraftServer server, Team team) {

common/src/main/java/dev/ftb/mods/ftbteambases/util/DimensionUtils.java

@@ -32,6 +32,7 @@
 import net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate;
 import net.minecraft.world.phys.Vec3;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.Objects;
 import java.util.Optional;
@@ -104,15 +105,19 @@ public static Stream<Holder<StructureSet>> possibleStructures(HolderLookup<Struc
         ).orElse(Stream.of());
     }
 
-    public static boolean teleport(ServerPlayer player, ResourceKey<Level> key, BlockPos destPos) {
+    public static boolean teleport(ServerPlayer player, ResourceKey<Level> key, @Nullable BlockPos destPos) {
+        return teleport(player, key, destPos, player.getYRot());
+    }
+
+    public static boolean teleport(ServerPlayer player, ResourceKey<Level> key, @Nullable BlockPos destPos, float yRot) {
         ServerLevel level = player.server.getLevel(key);
 
         if (level != null) {
-            if (key.equals(Level.OVERWORLD)) {
+            if (key.equals(ServerConfig.lobbyDimension().orElse(Level.OVERWORLD))) {
                 BlockPos lobbySpawnPos = BaseInstanceManager.get(player.server).getLobbySpawnPos();
                 BlockPos pos = Objects.requireNonNullElse(destPos, lobbySpawnPos);
 
-                doTeleport(player, level, pos);
+                doTeleport(player, level, pos, yRot);
             } else {
                 Vec3 vec;
                 if (destPos == null) {
@@ -129,7 +134,7 @@ public static boolean teleport(ServerPlayer player, ResourceKey<Level> key, Bloc
                     vec = Vec3.atCenterOf(destPos);
                 }
 
-                doTeleport(player, level, BlockPos.containing(vec.x, vec.y, vec.z));
+                doTeleport(player, level, BlockPos.containing(vec.x, vec.y, vec.z), yRot);
             }
             return true;
         } else {
@@ -138,11 +143,11 @@ public static boolean teleport(ServerPlayer player, ResourceKey<Level> key, Bloc
         }
     }
 
-    private static void doTeleport(ServerPlayer player, ServerLevel level, BlockPos pos) {
+    private static void doTeleport(ServerPlayer player, ServerLevel level, BlockPos pos, float yRot) {
         ChunkPos chunkpos = new ChunkPos(pos);
         level.getChunkSource().addRegionTicket(TicketType.POST_TELEPORT, chunkpos, 1, player.getId());
         player.stopRiding();
-        player.teleportTo(level, pos.getX() + .5D, pos.getY() + .01D, pos.getZ() + .5D, player.getYRot(), player.getXRot());
+        player.teleportTo(level, pos.getX() + .5D, pos.getY() + .01D, pos.getZ() + .5D, yRot, player.getXRot());
 
         FTBTeamBases.LOGGER.debug("teleported {} to {} in {}", player.getGameProfile().getName(), pos, level.dimension().location());
     }