Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signal (pretalx) for state change #96

Open
johanvdw opened this issue Feb 22, 2025 · 2 comments
Open

Add signal (pretalx) for state change #96

johanvdw opened this issue Feb 22, 2025 · 2 comments
Labels
pretalx-main Issues that make sure our customizations can run without forking pretalx

Comments

@johanvdw
Copy link
Member

We have some custom checks when a state change. These are now in our branch of pretalx.

We should create a signal in pretalx and listen to that and check:

  • that the change is made by a devroom manager of that track
@johanvdw johanvdw added the pretalx-main Issues that make sure our customizations can run without forking pretalx label Feb 22, 2025
@johanvdw
Copy link
Member Author

johanvdw commented Feb 22, 2025 •
edited
Loading

looks like a very related signal already exists:

https://github.com/pretalx/pretalx/blob/main/src/pretalx/submission/models/submission.py#L387C1-L392C14

submission_state_change

but this is after the change is done, I would like to have one before

@johanvdw
Copy link
Member Author

upstream issue: pretalx/pretalx#1974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pretalx-main Issues that make sure our customizations can run without forking pretalx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanvdw