Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider license name patterns #229

Open
AugustusKling opened this issue Dec 9, 2024 · 1 comment
Open

Reconsider license name patterns #229

AugustusKling opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed idea

Comments

@AugustusKling
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Not sure if current patterns for license files match all files they should match. Same for lookup table of MIME types.

Describe the solution you'd like

Try out different patterns and check if additional, valid license files are found in commonly used NPM packages. Then decide if the current pattern in #LICENSE_FILENAME_PATTERN and MAP_TEXT_EXTENSION_MIME are good as they are or need to be changed.

@AugustusKling AugustusKling added the enhancement New feature or request label Dec 9, 2024
@jkowalleck jkowalleck added help wanted Extra attention is needed idea labels Dec 10, 2024
@jkowalleck
Copy link
Member

At the moment, there are no reports of files missing or not being detected as expected.
This ticket is there, to collect all traces and ideas for missing files.

📣 Everybody, feel free to add doubts, so we can add additional test cases and release possible fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed idea
Projects
None yet
Development

No branches or pull requests

2 participants