Skip to content

Commit e445e5b

Browse files
committed
🔧 fixing #759
1 parent 8e94343 commit e445e5b

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

.github/workflows/ci.yml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,8 +579,21 @@ jobs:
579579
run: rm -r ./build
580580

581581
# trying if pulling the dependency with tipi works properly
582+
#
583+
# note: the xxhashsum sources include xxhash using a #include "../xxhash.h"
584+
# this defeats the purpose of this test AND becase a bug post tipi v0.0.35
585+
# because of source mirroring (not) supporting relative include to locations
586+
# outside of the project tree.
587+
#
588+
# because of this we create a copy of the ./cli and apply some sed magic
589+
# to make the includes proper 'library' includes to simulate what someone
590+
# consuming xxHash would do
591+
#
592+
# e.g. turning #include "../xxhash.h" => #include <xxhash.h>
582593
- name: Build as dependency
583594
run: |
584-
cd ./cli
595+
cp -a ./cli ./cli-tipi
596+
cd ./cli-tipi
597+
find ./ -type f -iname "*.c" | xargs sed -i 's;"../xxhash.h";<xxhash.h>;g'
585598
tipi . --dont-upgrade --verbose -t linux-cxx17
586599
./build/linux-cxx17/bin/xsum_os_specific

cli/.tipi/deps

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"Cyan4973/xxHash": { "@": "v0.8.1" }
2+
"Cyan4973/xxHash": { }
33
}

0 commit comments

Comments
 (0)