Skip to content

Add proper checks into BuildResource Action for JupyterBook/MyST build errors #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsnow03 opened this issue Apr 19, 2025 · 2 comments

Comments

@tsnow03
Copy link
Member

tsnow03 commented Apr 19, 2025

BuildResource Action does not catch JupyterBook/MyST build errors and so will deploy a faulty JupyterBook to the website. Need to add appropriate checks for these.

@tsnow03
Copy link
Member Author

tsnow03 commented Apr 19, 2025

@agoose77 I'm going to look into this on Monday, but if you know off the top of your head what to add into BuildResource.sh for checking and failing for the red errors that pop up during the build and create difference between the expected and built book, that would be great!

echo "Building the Jupyter Book"

@agoose77
Copy link
Contributor

@tsnow03 can you confirm whether the "red errors" that you're referring to are seen at build time (in the GitHub Actions console) or at deploy time (on the website)? We can't detect the latter because they're "runtime errors" in the website, rather than something that went wrong during the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants